From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 447E4C4338F for ; Tue, 3 Aug 2021 02:24:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2510361037 for ; Tue, 3 Aug 2021 02:24:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233700AbhHCCYg (ORCPT ); Mon, 2 Aug 2021 22:24:36 -0400 Received: from smtpbg704.qq.com ([203.205.195.105]:41863 "EHLO smtpproxy21.qq.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233619AbhHCCYW (ORCPT ); Mon, 2 Aug 2021 22:24:22 -0400 X-QQ-mid: bizesmtp38t1627957442tpqpcyqc Received: from localhost.localdomain (unknown [113.57.152.160]) by esmtp6.qq.com (ESMTP) with id ; Tue, 03 Aug 2021 10:24:01 +0800 (CST) X-QQ-SSF: 0140000000200050B000B00A0000000 X-QQ-FEAT: Ry58bBY793t8J05YGMEb+oM4QxhzoNKqMDKOSIqF/miICeODdH/7BMzYL6Z+I f43TZnqv2iYUA5HyiOlp0Y74r3x9qJsncJR1BEniCjsBWOMLDm9Rci7ENMSjNpFCvqTYBKK sm93nw54FHYRAY1B9FUp78skywDoP67N1YbGwVA0DsSMuhMaLkiNWPSEe7C1o2lbFkqB5OK UzrGZp+/ze+xsChCun92Wat55pKcsxMvED+C3XtQSY8JZJxMVpQK+o9RrPChkegC9cpgukE HigewXuWO8vOEyUr7N0rB7jH312J5Txat9b3rnLt2L+KXesRIbDkaNKkKjhwmXcChjpHlJ6 lVv3J5PGvkIgeinu6SOj3GyJFQPoSoK+0D2P7lN6RGJbbK6HoQ= X-QQ-GoodBg: 2 From: Hao Chen To: peppe.cavallaro@st.com Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, kuba@kernel.org, mcoquelin.stm32@gmail.com, linux@armlinux.org.uk, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Hao Chen Subject: [net-next,v8] net: stmmac: optimize check in ops '.begin' Date: Tue, 3 Aug 2021 10:23:13 +0800 Message-Id: <20210803022313.23612-1-chenhaoa@uniontech.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:uniontech.com:qybgforeign:qybgforeign5 X-QQ-Bgrelay: 1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I want to get permanent MAC address when the interface is down. And I think it is more convenient to get statistics in the down state by 'ethtool -S'. But current all of the ethool command return -EBUSY. I don't think we should check that the network interface is up in '.begin', which will cause that all the ethtool commands can't be used when the network interface is down. If some ethtool commands can only be used in the up state, check it in the corresponding ethool OPS function is better. This is too rude and unreasonable. Compile-tested on arm64. Tested on an arm64 system with an on-board STMMAC chip. Changes v7 ... v8: - Optimize commit description information, optimization parameters of pm_runtime function. Changes v6 ... v7: - fix arg type error of 'dev' to 'priv->device'. Changes v5 ... v6: - The 4.19.90 kernel not support pm_runtime, so implemente '.begin' and '.complete' again. Add return value check of pm_runtime function. Changes v4 ... v5: - test the '.begin' will return -13 error on my machine based on 4.19.90 kernel. The platform driver does not supported pm_runtime. So remove the implementation of '.begin' and '.complete'. Changes v3 ... v4: - implement '.complete' ethtool OPS. Changes v2 ... v3: - add linux/pm_runtime.h head file. Changes v1 ... v2: - fix spell error of dev. Signed-off-by: Hao Chen --- .../ethernet/stmicro/stmmac/stmmac_ethtool.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index d0ce608b81c3..8e2ae0ff7f8f 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -12,8 +12,9 @@ #include #include #include -#include #include +#include +#include #include #include "stmmac.h" @@ -410,11 +411,14 @@ static void stmmac_ethtool_setmsglevel(struct net_device *dev, u32 level) } -static int stmmac_check_if_running(struct net_device *dev) +static int stmmac_ethtool_begin(struct net_device *dev) { - if (!netif_running(dev)) - return -EBUSY; - return 0; + return pm_runtime_resume_and_get(dev->dev); +} + +static void stmmac_ethtool_complete(struct net_device *dev) +{ + pm_runtime_put(dev->dev); } static int stmmac_ethtool_get_regs_len(struct net_device *dev) @@ -1073,7 +1077,8 @@ static int stmmac_set_tunable(struct net_device *dev, static const struct ethtool_ops stmmac_ethtool_ops = { .supported_coalesce_params = ETHTOOL_COALESCE_USECS | ETHTOOL_COALESCE_MAX_FRAMES, - .begin = stmmac_check_if_running, + .begin = stmmac_ethtool_begin, + .complete = stmmac_ethtool_complete, .get_drvinfo = stmmac_ethtool_getdrvinfo, .get_msglevel = stmmac_ethtool_getmsglevel, .set_msglevel = stmmac_ethtool_setmsglevel, -- 2.20.1