From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-26.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA8BFC4338F for ; Wed, 4 Aug 2021 21:43:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A843F60C3F for ; Wed, 4 Aug 2021 21:43:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233906AbhHDVoC (ORCPT ); Wed, 4 Aug 2021 17:44:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233664AbhHDVn6 (ORCPT ); Wed, 4 Aug 2021 17:43:58 -0400 Received: from mail-qt1-x84a.google.com (mail-qt1-x84a.google.com [IPv6:2607:f8b0:4864:20::84a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 090E3C061798 for ; Wed, 4 Aug 2021 14:43:44 -0700 (PDT) Received: by mail-qt1-x84a.google.com with SMTP id o7-20020ac87c470000b029025f8084df09so1687938qtv.6 for ; Wed, 04 Aug 2021 14:43:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=Yfvc1y59oR5+LtzVBBauZFH1r/tvrwxUqR7lrvF7mpY=; b=kTmOFrP7L/yw8DPyAq+Z9PdmavFp56OCF/BKatjh3C5PTq4hbHOwJh7VYSOlTzbvZf lgzgeD7Ao1klgXljKIqzg4sby9v4uAyNdWwihF0so/j4O51xLfiiwAn7dbpEiQIsUJps br2k7Fzr1t8Yc4z60bh5FtEiwgaC+4v6C3knP+d8rlmMUXNdIpHQIYTSfrCQut2NBnkc l+HgGMMqRjeuG9+MvsKONbR+4CXKUkiIKeOh/e3Luv4Inn+eZHio8mBFI5oRBgbBRVAF riSUm2NwDCGnE4Bw48DmmM+qkSYF3ikncB5BTYe4vXD+EoWPaTFLP4eqZrapz6vPqOdA Pi+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=Yfvc1y59oR5+LtzVBBauZFH1r/tvrwxUqR7lrvF7mpY=; b=glPuma3pU2i9Sjaek7TGVIHNvMaXSnJddOLvAV50/oIBZnXZmsLuJ7duCvPqyG6lcd msgXb6yxxKHnaTWnR/ApZOPIpuV4BIcXY0w+W0tUbnIG4187borX+WaKxrQwGWAU3r9e y1eKvZbXWzOQLbDxdP99904mdUogMW0sy7hxdIpaMPJMGajc4DZWRwRGNlP3jsawWoum BVe813U6OSaaawFSThvDretdUjM+FZ2CvrUzPgu6jnXzolv94+Zj++eIIEliXh7ymVGX Hsx1uo1X1Mox4tgA1RV5nI8hal3PvjV6zUWRFKGD7ZKC/g8tsPorSubChnk7NGaJdN9o mGIw== X-Gm-Message-State: AOAM531X/RhS84Oncz/jInl8sKz0G2GwK0riHPadGyb65aFJgK9FOR5C fNuC2B4RbShM5z515+cm7ArKnNrRslolwJA= X-Google-Smtp-Source: ABdhPJxP4qxypc1Lm8WQZTN0xdIV9kZ1Q3kp6P0dl9diA/2iCpr9UsfvSrl8gf3HIuwSOzKOn85j6PDmXnySW5A= X-Received: from saravanak.san.corp.google.com ([2620:15c:2d:3:ffe5:1245:526e:3189]) (user=saravanak job=sendgmr) by 2002:ad4:55d0:: with SMTP id bt16mr1690482qvb.49.1628113423244; Wed, 04 Aug 2021 14:43:43 -0700 (PDT) Date: Wed, 4 Aug 2021 14:43:31 -0700 In-Reply-To: <20210804214333.927985-1-saravanak@google.com> Message-Id: <20210804214333.927985-3-saravanak@google.com> Mime-Version: 1.0 References: <20210804214333.927985-1-saravanak@google.com> X-Mailer: git-send-email 2.32.0.554.ge1b32706d8-goog Subject: [PATCH v1 2/3] net: mdio-mux: Don't ignore memory allocation errors From: Saravana Kannan To: Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski Cc: Saravana Kannan , Marc Zyngier , Neil Armstrong , Kevin Hilman , kernel-team@android.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If we are seeing memory allocation errors, don't try to continue registering child mdiobus devices. It's unlikely they'll succeed. Signed-off-by: Saravana Kannan --- drivers/net/mdio/mdio-mux.c | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/drivers/net/mdio/mdio-mux.c b/drivers/net/mdio/mdio-mux.c index 5b37284f54d6..13035e2685c4 100644 --- a/drivers/net/mdio/mdio-mux.c +++ b/drivers/net/mdio/mdio-mux.c @@ -82,6 +82,17 @@ static int mdio_mux_write(struct mii_bus *bus, int phy_id, static int parent_count; +static void mdio_mux_uninit_children(struct mdio_mux_parent_bus *pb) +{ + struct mdio_mux_child_bus *cb = pb->children; + + while (cb) { + mdiobus_unregister(cb->mii_bus); + mdiobus_free(cb->mii_bus); + cb = cb->next; + } +} + int mdio_mux_init(struct device *dev, struct device_node *mux_node, int (*switch_fn)(int cur, int desired, void *data), @@ -144,7 +155,7 @@ int mdio_mux_init(struct device *dev, cb = devm_kzalloc(dev, sizeof(*cb), GFP_KERNEL); if (!cb) { ret_val = -ENOMEM; - continue; + goto err_loop; } cb->bus_number = v; cb->parent = pb; @@ -152,8 +163,7 @@ int mdio_mux_init(struct device *dev, cb->mii_bus = mdiobus_alloc(); if (!cb->mii_bus) { ret_val = -ENOMEM; - devm_kfree(dev, cb); - continue; + goto err_loop; } cb->mii_bus->priv = cb; @@ -181,6 +191,10 @@ int mdio_mux_init(struct device *dev, } dev_err(dev, "Error: No acceptable child buses found\n"); + +err_loop: + mdio_mux_uninit_children(pb); + of_node_put(child_bus_node); err_pb_kz: put_device(&parent_bus->dev); err_parent_bus: @@ -192,14 +206,8 @@ EXPORT_SYMBOL_GPL(mdio_mux_init); void mdio_mux_uninit(void *mux_handle) { struct mdio_mux_parent_bus *pb = mux_handle; - struct mdio_mux_child_bus *cb = pb->children; - - while (cb) { - mdiobus_unregister(cb->mii_bus); - mdiobus_free(cb->mii_bus); - cb = cb->next; - } + mdio_mux_uninit_children(pb); put_device(&pb->mii_bus->dev); } EXPORT_SYMBOL_GPL(mdio_mux_uninit); -- 2.32.0.554.ge1b32706d8-goog