From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH,
	MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 8690EC4338F
	for <linux-kernel@archiver.kernel.org>; Sun,  8 Aug 2021 15:07:55 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 5C6BD6023E
	for <linux-kernel@archiver.kernel.org>; Sun,  8 Aug 2021 15:07:55 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232093AbhHHPIK (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Sun, 8 Aug 2021 11:08:10 -0400
Received: from foss.arm.com ([217.140.110.172]:42408 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S231137AbhHHPII (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 8 Aug 2021 11:08:08 -0400
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
        by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C58F6D;
        Sun,  8 Aug 2021 08:07:49 -0700 (PDT)
Received: from e120937-lin (unknown [172.31.20.19])
        by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 06D223F718;
        Sun,  8 Aug 2021 08:07:47 -0700 (PDT)
Date:   Sun, 8 Aug 2021 16:07:41 +0100
From:   Cristian Marussi <cristian.marussi@arm.com>
To:     Sudeep Holla <sudeep.holla@arm.com>
Cc:     Igor Skalkin <igor.skalkin@opensynergy.com>,
        kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
        kernel test robot <lkp@intel.com>,
        Peter Hilber <peter.hilber@opensynergy.com>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: arm_scmi: fix boolconv.cocci warnings
Message-ID: <20210808150741.GW6592@e120937-lin>
References: <202108080108.k5pHZ040-lkp@intel.com>
 <20210807173127.GA43248@a24dbc127934>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210807173127.GA43248@a24dbc127934>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sun, Aug 08, 2021 at 01:31:27AM +0800, kernel test robot wrote:
> From: kernel test robot <lkp@intel.com>
> 
> drivers/firmware/arm_scmi/virtio.c:225:40-45: WARNING: conversion to bool not needed here
> 
>  Remove unneeded conversion to bool
> 
> Semantic patch information:
>  Relational and logical operators evaluate to bool,
>  explicit conversion is overly verbose and unneeded.
> 
> Generated by: scripts/coccinelle/misc/boolconv.cocci
> 
> CC: Igor Skalkin <igor.skalkin@opensynergy.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> 
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git for-next/scmi
> head:   1e7cbfaa66d39e78bd24df0c78b55df68176b59e
> commit: 46abe13b5e3db187e52cd0de06c07bbce010726c [23/24] firmware: arm_scmi: Add virtio transport
> :::::: branch date: 2 days ago
> :::::: commit date: 2 days ago
> 
>  virtio.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/firmware/arm_scmi/virtio.c
> +++ b/drivers/firmware/arm_scmi/virtio.c
> @@ -222,7 +222,7 @@ static bool virtio_chan_available(struct
>  		return false;
>  	}
>  
> -	return vioch && !vioch->cinfo ? true : false;
> +	return vioch && !vioch->cinfo;
>  }
>  
>  static int virtio_chan_setup(struct scmi_chan_info *cinfo, struct device *dev,o

Hi Sudeep,

this seems obviously right, would you pick it up as it is on top of
for-next/scmi when you have time ?

Thanks,
Cristian