From: Ian Pilcher <arequipeno@gmail.com>
To: linux-block@vger.kernel.org, linux-leds@vger.kernel.org
Cc: axboe@kernel.dk, pavel@ucw.cz, linux-kernel@vger.kernel.org,
kernelnewbies@kernelnewbies.org
Subject: [RFC PATCH v2 06/10] block: Add activate and deactivate functions for block device LED trigger
Date: Sun, 8 Aug 2021 22:32:13 -0500 [thread overview]
Message-ID: <20210809033217.1113444-7-arequipeno@gmail.com> (raw)
In-Reply-To: <20210809033217.1113444-1-arequipeno@gmail.com>
Set up activated LED:
* Allocate per-LED data structure
* Add LED to list of LEDs associated with blkdev trigger
* Create block_devices subdirectory for links to associated devices
Clean up deactivated LED:
* Clear LED of any associated devices
* Remove from LED from blkdev trigger list
* Remove block_devices subdirectory
* Wait for any blinks using LED to complete (synchronize_rcu())
* Free per-LED structure
Signed-off-by: Ian Pilcher <arequipeno@gmail.com>
---
block/blk-ledtrig.c | 95 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 95 insertions(+)
diff --git a/block/blk-ledtrig.c b/block/blk-ledtrig.c
index 1af94dc7ea51..f8cb6de203f8 100644
--- a/block/blk-ledtrig.c
+++ b/block/blk-ledtrig.c
@@ -13,6 +13,11 @@
#include "blk-ledtrig.h"
+// Default blink_on & blink_off values
+#define BLK_LEDTRIG_BLINK_ON 75
+#define BLK_LEDTRIG_BLINK_OFF 25
+#define BLK_LEDTRIG_BLINK_MAX 10000 // 10 seconds
+
/*
*
@@ -248,3 +253,93 @@ ssize_t blk_ledtrig_dev_led_show(struct device *const dev,
led_show_exit_return:
return ret;
}
+
+
+/*
+ *
+ * Associate an LED with the blkdev trigger
+ *
+ */
+
+// Helper function to create <LED>/blkdevs subdirectory - doesn't
+// swallow error code like kobject_create_and_add()
+static int blk_ledtrig_subdir_create(struct blk_ledtrig_led *const bd_led,
+ struct led_classdev *const led)
+{
+ int ret;
+
+ bd_led->dir = kobject_create();
+ if (bd_led->dir == NULL)
+ return -ENOMEM;
+
+ ret = kobject_add(bd_led->dir, &led->dev->kobj, "block_devices");
+ if (ret != 0)
+ kobject_put(bd_led->dir);
+
+ return ret;
+}
+
+static int blk_ledtrig_activate(struct led_classdev *const led)
+{
+ struct blk_ledtrig_led *bd_led;
+ int ret;
+
+ bd_led = kmalloc(sizeof(*bd_led), GFP_KERNEL);
+ if (bd_led == NULL) {
+ ret = -ENOMEM;
+ goto activate_exit_return;
+ }
+
+ bd_led->led = led;
+ bd_led->blink_on = BLK_LEDTRIG_BLINK_ON;
+ bd_led->blink_off = BLK_LEDTRIG_BLINK_OFF;
+ INIT_LIST_HEAD(&bd_led->dev_list);
+
+ ret = mutex_lock_interruptible(&blk_ledtrig_mutex);
+ if (ret != 0)
+ goto activate_exit_free;
+
+ ret = blk_ledtrig_subdir_create(bd_led, led);
+ if (ret != 0)
+ goto activate_exit_unlock;
+
+ list_add(&bd_led->leds_list_node, &blk_ledtrig_leds);
+ led_set_trigger_data(led, bd_led);
+ ret = 0;
+
+activate_exit_unlock:
+ mutex_unlock(&blk_ledtrig_mutex);
+activate_exit_free:
+ if (ret != 0)
+ kfree(bd_led);
+activate_exit_return:
+ return ret;
+}
+
+
+/*
+ *
+ * Disassociate an LED from the blkdev trigger
+ *
+ */
+
+static void blk_ledtrig_deactivate(struct led_classdev *const led)
+{
+ struct blk_ledtrig_led *const bd_led = led_get_trigger_data(led);
+ struct gendisk *disk, *next;
+
+ mutex_lock(&blk_ledtrig_mutex);
+
+ list_for_each_entry_safe(disk, next,
+ &bd_led->dev_list, led_dev_list_node) {
+
+ blk_ledtrig_dev_clear_locked(disk, bd_led);
+ }
+
+ list_del(&bd_led->leds_list_node);
+ kobject_put(bd_led->dir);
+
+ mutex_unlock(&blk_ledtrig_mutex);
+ synchronize_rcu();
+ kfree(bd_led);
+}
--
2.31.1
next prev parent reply other threads:[~2021-08-09 3:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 3:32 [RFC PATCH v2 00/10] Add configurable block device LED triggers Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 01/10] docs: Add block device LED trigger documentation Ian Pilcher
2021-08-10 13:49 ` Pavel Machek
2021-08-09 3:32 ` [RFC PATCH v2 02/10] block: Add file (blk-ledtrig.c) for block device LED trigger implementation Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 03/10] block: Add block device LED trigger fields to gendisk structure Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 04/10] block: Add functions to set & clear block device LEDs Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 05/10] block: Add block device sysfs attribute to set/clear/show LED Ian Pilcher
2021-08-09 4:21 ` Jackie Liu
2021-08-09 15:44 ` Ian Pilcher
2021-08-09 3:32 ` Ian Pilcher [this message]
2021-08-09 3:32 ` [RFC PATCH v2 07/10] block: Add sysfs attributes to LEDs associated with blkdev trigger Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 08/10] block: Add init function for block device LED trigger Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 09/10] block: Blink device LED (if any) when request is sent to its driver Ian Pilcher
2021-08-09 3:32 ` [RFC PATCH v2 10/10] block: Add config option to enable block device LED triggers Ian Pilcher
2021-08-09 18:56 ` [RFC PATCH v2 00/10] Add configurable " Marek Behún
2021-08-09 19:07 ` Pali Rohár
2021-08-09 19:54 ` Ian Pilcher
2021-08-09 22:43 ` Marek Behún
2021-08-09 23:50 ` Ian Pilcher
2021-08-10 6:35 ` Greg KH
2021-08-10 13:38 ` Marek Behún
2021-08-10 14:48 ` Greg KH
2021-08-10 15:55 ` Ian Pilcher
2021-08-10 16:24 ` Greg KH
2021-08-10 16:39 ` Marek Behún
2021-08-10 16:43 ` Ian Pilcher
2021-08-11 6:26 ` Christoph Hellwig
2021-08-11 10:50 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210809033217.1113444-7-arequipeno@gmail.com \
--to=arequipeno@gmail.com \
--cc=axboe@kernel.dk \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®