From: Dongliang Mu <mudongliangabcd@gmail.com>
To: Samuel Iglesias Gonsalvez <siglesias@igalia.com>,
Jens Taprogge <jens.taprogge@taprogge.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dongliang Mu <mudongliangabcd@gmail.com>,
Randy Dunlap <rdunlap@infradead.org>,
Lv Yunlong <lyl2019@mail.ustc.edu.cn>,
Aditya Srivastava <yashsri421@gmail.com>
Cc: industrypack-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/4] ipack: tpci200: change pci_iounmap to iounmap
Date: Mon, 9 Aug 2021 22:30:28 +0800 [thread overview]
Message-ID: <20210809143049.3531188-3-mudongliangabcd@gmail.com> (raw)
In-Reply-To: <20210809143049.3531188-1-mudongliangabcd@gmail.com>
The deallocation api for ioremap should be iounmap, other than
pci_iounmap.
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
---
drivers/ipack/carriers/tpci200.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/ipack/carriers/tpci200.c b/drivers/ipack/carriers/tpci200.c
index b1562b881cd1..307f94f59c18 100644
--- a/drivers/ipack/carriers/tpci200.c
+++ b/drivers/ipack/carriers/tpci200.c
@@ -88,7 +88,7 @@ static void tpci200_unregister(struct tpci200_board *tpci200)
{
free_irq(tpci200->info->pdev->irq, (void *) tpci200);
- pci_iounmap(tpci200->info->pdev, tpci200->info->interface_regs);
+ iounmap(tpci200->info->pdev, tpci200->info->interface_regs);
pci_release_region(tpci200->info->pdev, TPCI200_IP_INTERFACE_BAR);
pci_release_region(tpci200->info->pdev, TPCI200_IO_ID_INT_SPACES_BAR);
@@ -347,7 +347,7 @@ static int tpci200_register(struct tpci200_board *tpci200)
return 0;
err_interface_regs:
- pci_iounmap(tpci200->info->interface_regs);
+ iounmap(tpci200->info->interface_regs);
err_mem16_space_bar:
pci_release_region(tpci200->info->pdev, TPCI200_MEM16_SPACE_BAR);
err_mem8_space_bar:
@@ -596,7 +596,7 @@ static int tpci200_pci_probe(struct pci_dev *pdev,
err_tpci200_install:
tpci200_uninstall(tpci200);
err_cfg_regs:
- pci_iounmap(tpci200->info->cfg_regs);
+ iounmap(tpci200->info->cfg_regs);
err_request_region:
pci_release_region(pdev, TPCI200_CFG_MEM_BAR);
err_tpci200_info:
@@ -612,7 +612,7 @@ static void __tpci200_pci_remove(struct tpci200_board *tpci200)
ipack_bus_unregister(tpci200->info->ipack_bus);
tpci200_uninstall(tpci200);
- pci_iounmap(tpci200->info->cfg_regs);
+ iounmap(tpci200->info->cfg_regs);
pci_release_region(tpci200->info->pdev, TPCI200_CFG_MEM_BAR);
pci_dev_put(tpci200->info->pdev);
--
2.25.1
next prev parent reply other threads:[~2021-08-09 14:31 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 14:30 [PATCH v2 1/4] ipack: tpci200: fix many double free issues in tpci200_pci_probe Dongliang Mu
2021-08-09 14:30 ` [PATCH v2 2/4] ipack: tpci200: fix memory leak in the tpci200_register Dongliang Mu
2021-08-09 15:32 ` Greg Kroah-Hartman
2021-08-09 23:09 ` Dongliang Mu
2021-08-10 6:09 ` Greg Kroah-Hartman
2021-08-09 14:30 ` Dongliang Mu [this message]
2021-08-09 15:33 ` [PATCH v2 3/4] ipack: tpci200: change pci_iounmap to iounmap Greg Kroah-Hartman
2021-08-09 18:22 ` kernel test robot
2021-08-09 18:29 ` Andy Shevchenko
2021-08-09 21:23 ` kernel test robot
2021-08-09 14:30 ` [PATCH v2 4/4] ipack: tpci200: move tpci200_unregister close to tpci200_register Dongliang Mu
2021-08-09 15:33 ` Greg Kroah-Hartman
2021-08-09 23:54 ` Dongliang Mu
2021-08-09 15:32 ` [PATCH v2 1/4] ipack: tpci200: fix many double free issues in tpci200_pci_probe Greg Kroah-Hartman
2021-08-09 23:08 ` Dongliang Mu
2021-08-09 23:41 ` Dongliang Mu
2021-08-10 6:12 ` Greg Kroah-Hartman
2021-08-10 6:27 ` Dongliang Mu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210809143049.3531188-3-mudongliangabcd@gmail.com \
--to=mudongliangabcd@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=industrypack-devel@lists.sourceforge.net \
--cc=jens.taprogge@taprogge.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lyl2019@mail.ustc.edu.cn \
--cc=rdunlap@infradead.org \
--cc=siglesias@igalia.com \
--cc=yashsri421@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®