Re: [PATCH v3 6/9] ASoC: mediatek: mt8195: add platform driver

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3590 bytes --]

Hi Trevor,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on asoc/for-next]
[also build test WARNING on spi/for-next sound/for-next v5.14-rc5 next-20210806]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Trevor-Wu/ASoC-mediatek-Add-support-for-MT8195-SoC/20210809-175133
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/67c1e85ec1f88b1e5554b402e54ad6224a1398f7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Trevor-Wu/ASoC-mediatek-Add-support-for-MT8195-SoC/20210809-175133
        git checkout 67c1e85ec1f88b1e5554b402e54ad6224a1398f7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> sound/soc/mediatek/mt8195/mt8195-afe-clk.c:437:5: warning: no previous prototype for 'mt8195_afe_enable_timing_sys' [-Wmissing-prototypes]
     437 | int mt8195_afe_enable_timing_sys(struct mtk_base_afe *afe)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> sound/soc/mediatek/mt8195/mt8195-afe-clk.c:460:5: warning: no previous prototype for 'mt8195_afe_disable_timing_sys' [-Wmissing-prototypes]
     460 | int mt8195_afe_disable_timing_sys(struct mtk_base_afe *afe)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/mt8195_afe_enable_timing_sys +437 sound/soc/mediatek/mt8195/mt8195-afe-clk.c

   436	
 > 437	int mt8195_afe_enable_timing_sys(struct mtk_base_afe *afe)
   438	{
   439		struct mt8195_afe_private *afe_priv = afe->platform_priv;
   440		int i;
   441		unsigned int clk_array[] = {
   442			MT8195_CLK_AUD_A1SYS,
   443			MT8195_CLK_AUD_A2SYS,
   444		};
   445		unsigned int cg_array[] = {
   446			MT8195_TOP_CG_A1SYS_TIMING,
   447			MT8195_TOP_CG_A2SYS_TIMING,
   448			MT8195_TOP_CG_26M_TIMING,
   449		};
   450	
   451		for (i = 0; i < ARRAY_SIZE(clk_array); i++)
   452			mt8195_afe_enable_clk(afe, afe_priv->clk[clk_array[i]]);
   453	
   454		for (i = 0; i < ARRAY_SIZE(cg_array); i++)
   455			mt8195_afe_enable_top_cg(afe, cg_array[i]);
   456	
   457		return 0;
   458	}
   459	
 > 460	int mt8195_afe_disable_timing_sys(struct mtk_base_afe *afe)
   461	{
   462		struct mt8195_afe_private *afe_priv = afe->platform_priv;
   463		int i;
   464		unsigned int clk_array[] = {
   465			MT8195_CLK_AUD_A2SYS,
   466			MT8195_CLK_AUD_A1SYS,
   467		};
   468		unsigned int cg_array[] = {
   469			MT8195_TOP_CG_26M_TIMING,
   470			MT8195_TOP_CG_A2SYS_TIMING,
   471			MT8195_TOP_CG_A1SYS_TIMING,
   472		};
   473	
   474		for (i = 0; i < ARRAY_SIZE(cg_array); i++)
   475			mt8195_afe_disable_top_cg(afe, cg_array[i]);
   476	
   477		for (i = 0; i < ARRAY_SIZE(clk_array); i++)
   478			mt8195_afe_disable_clk(afe, afe_priv->clk[clk_array[i]]);
   479	
   480		return 0;
   481	}
   482	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 70955 bytes --]