From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73C84C432BE for ; Tue, 10 Aug 2021 13:52:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 525D560EE7 for ; Tue, 10 Aug 2021 13:52:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241974AbhHJNxF (ORCPT ); Tue, 10 Aug 2021 09:53:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:58954 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233318AbhHJNxE (ORCPT ); Tue, 10 Aug 2021 09:53:04 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A8A5C60295; Tue, 10 Aug 2021 13:52:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628603562; bh=0pxQiHwlv5O2WEojRWriWbYYkFrCPIve7BAoLdArVsk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qEEtohrcG1EUKK2c+wB0W2pTvC4aR1XmtTsnjb9xWBkWW74Fk2pW2uSiJaHF+0rN5 OSJShqFkjO9TB7gOsQWqAJ2IosfcaoTjlUyZSVKnsdeOmOS98Z93k3RT3pgIbU7OFJ gQwoug16z4QgKF2v1DzrAiu+mCRfXJtQjf4pd34JniFShMTHb3pzt49plBR0nqofZM p0mTyParYgNuvP26wXI4DWQ6Blfue4+TewnBPKxSPG52VEr6d60WbsJlHJlo8pxd8r InsgZRkA4JRAFp/f0KQYl0G+RiXekkHg/Hx0M25lX01RHBFV84m7nrjz+C5OqNo2Y3 MawnrvY5x7sTg== Date: Tue, 10 Aug 2021 14:52:36 +0100 From: Will Deacon To: Andrew Delgadillo Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, masahiroy@kernel.org Subject: Re: [PATCH] arm64: clean vdso files Message-ID: <20210810135236.GA3101@willie-the-truck> References: <20210809191414.3572827-1-adelg@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210809191414.3572827-1-adelg@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+Masahiro] On Mon, Aug 09, 2021 at 07:14:14PM +0000, Andrew Delgadillo wrote: > commit a5b8ca97fbf8 ("arm64: do not descend to vdso directories twice") > changes the cleaning behavior of arm64's vdso files, in that vdso.lds, > vdso.so, and vdso.so.dbg are not removed upon a 'make clean/mrproper': > > $ make defconfig ARCH=arm64 > $ make ARCH=arm64 > $ make mrproper ARCH=arm64 > $ git clean -nxdf > Would remove arch/arm64/kernel/vdso/vdso.lds > Would remove arch/arm64/kernel/vdso/vdso.so > Would remove arch/arm64/kernel/vdso/vdso.so.dbg > > To remedy this, manually descend into arch/arm64/kernel/vdso upon > cleaning. > > After this commit: > $ make defconfig ARCH=arm64 > $ make ARCH=arm64 > $ make mrproper ARCH=arm64 > $ git clean -nxdf > Well spotted! > Signed-off-by: Andrew Delgadillo > --- > arch/arm64/Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile > index b52481f0605d..ef6598cb5a9b 100644 > --- a/arch/arm64/Makefile > +++ b/arch/arm64/Makefile > @@ -181,6 +181,7 @@ archprepare: > # We use MRPROPER_FILES and CLEAN_FILES now > archclean: > $(Q)$(MAKE) $(clean)=$(boot) > + $(Q)$(MAKE) $(clean)=arch/arm64/kernel/vdso I think we also need to clean the vdso32 directory here. Please can you send a v2 with that added? Cheers, Will