From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90B91C4320A for ; Tue, 10 Aug 2021 20:50:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 71ACA610A3 for ; Tue, 10 Aug 2021 20:50:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233163AbhHJUvM (ORCPT ); Tue, 10 Aug 2021 16:51:12 -0400 Received: from mga04.intel.com ([192.55.52.120]:16577 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232783AbhHJUvL (ORCPT ); Tue, 10 Aug 2021 16:51:11 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10072"; a="213136584" X-IronPort-AV: E=Sophos;i="5.84,310,1620716400"; d="scan'208";a="213136584" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 13:50:49 -0700 X-IronPort-AV: E=Sophos;i="5.84,310,1620716400"; d="scan'208";a="421337800" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Aug 2021 13:50:46 -0700 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id EE8AB20345; Tue, 10 Aug 2021 23:50:43 +0300 (EEST) Date: Tue, 10 Aug 2021 23:50:43 +0300 From: Sakari Ailus To: Evgeny Novikov Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , Alex Dewar , Colin Ian King , Linus Walleij , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: Re: [PATCH v2] media: atomisp: Fix error handling in probe Message-ID: <20210810205043.GK3@paasikivi.fi.intel.com> References: <20210810162943.19852-1-novikov@ispras.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210810162943.19852-1-novikov@ispras.ru> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 10, 2021 at 07:29:43PM +0300, Evgeny Novikov wrote: > There were several issues with handling errors in lm3554_probe(): > - Probe did not set the error code when v4l2_ctrl_handler_init() failed. > - It intermixed gotos for handling errors of v4l2_ctrl_handler_init() > and media_entity_pads_init(). > - It did not set the error code for failures of v4l2_ctrl_new_custom(). > - Probe did not free resources in case of failures of > atomisp_register_i2c_module(). > > The patch fixes all these issues. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Evgeny Novikov Acked-by: Sakari Ailus -- Sakari Ailus