From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4AFEC4320A for ; Tue, 10 Aug 2021 22:46:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8D9A60FC4 for ; Tue, 10 Aug 2021 22:46:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235162AbhHJWqW (ORCPT ); Tue, 10 Aug 2021 18:46:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235093AbhHJWqV (ORCPT ); Tue, 10 Aug 2021 18:46:21 -0400 Received: from mail-qk1-x74a.google.com (mail-qk1-x74a.google.com [IPv6:2607:f8b0:4864:20::74a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E3CDC0613D3 for ; Tue, 10 Aug 2021 15:45:59 -0700 (PDT) Received: by mail-qk1-x74a.google.com with SMTP id s16-20020a05620a0810b02903d250dfc6a7so129736qks.5 for ; Tue, 10 Aug 2021 15:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=reply-to:date:message-id:mime-version:subject:from:to:cc; bh=eL5s2kUdV+92xFyW3SM6VFXr8+0Pvf4Nps5WWhKV5Uc=; b=kg5Fk9UmoJz3x/fwBOfqtRzHd15cZg/zW6cis5AKXZMrURfNBbNRt8Qp3zQoA0rHwV OMi1CYFICwGnyLOWITkdd6+VnHJlOBwqDUMSz5Tyy+z87Z2VqvOLH8HAoEjlGd+i26XD HFDdDNvsw0Hts5SahirPHgNmCoz/WiAzm1WGwtHTeNbbNeLa8KEsb02moydfomI13dUC nQ11G32tDHTZjYmYU5vrTjFasuY9g4VPVAZml7X/cT9v0TqIusCygtdy7ffH+UyK+vO6 ZLSQHDfbZcRWvgu0jm7pwrf7SLdszggCOAjj2OiIKW+WVoDHQeX72PlpTjL5/nb9+iHc +r6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:date:message-id:mime-version:subject :from:to:cc; bh=eL5s2kUdV+92xFyW3SM6VFXr8+0Pvf4Nps5WWhKV5Uc=; b=tcseGYhNYP21cBci0ykC4J8neZLpk0Q/Q14ZfAEIxfUArwvzNDpmkMnMv2Y8Z63qpR Bj98n2DyZeJGiM96jrF+X+suWEVBzO9g7GguinWCYKkg1f/xO8eK+WCISRFvKWRecx+S rgF8GL3A3EvjoLQ8xm39CVjCYze+uz6c5HLUOU+5GtO6CzvJI2AcT1s2PveAuvl9eWVI wpF5yfjk8nn9oyXNPSp7RGOEM5QyGMDyZ4pJ0xe1rfRFtwNLPVmC7dAtMGvdOXkxhFBx ZMN2YGSur2DTCiFz6O/Fy5f+g7O/aVAwaYOc+ro1lMj6hslpRdkeb3oCRoVk7ibzmcRr lPhA== X-Gm-Message-State: AOAM532DvMN1z8m7HD0xS05CIJbB0AlGanAFkyJ7xjdh+ZAgEHeJX4ZD X4M7z3UVdOR2jtuRMPB/BPx2sHXLNn0= X-Google-Smtp-Source: ABdhPJzwyzRaDLOx3GRlFxqMEuObzK3tawIVjRbfhlWiHECBUVNSBMw/O/dPef0ZdTYihK6U5WCNqZzm1Mw= X-Received: from seanjc798194.pdx.corp.google.com ([2620:15c:90:200:1c47:622e:7a2a:372d]) (user=seanjc job=sendgmr) by 2002:ad4:57a3:: with SMTP id g3mr6056782qvx.58.1628635558237; Tue, 10 Aug 2021 15:45:58 -0700 (PDT) Reply-To: Sean Christopherson Date: Tue, 10 Aug 2021 15:45:52 -0700 Message-Id: <20210810224554.2978735-1-seanjc@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.32.0.605.g8dce9f2422-goog Subject: [PATCH 0/2] KVM: x86/mmu: Fix unsync races within TDP MMU From: Sean Christopherson To: Paolo Bonzini Cc: Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Gardon Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Patch 1 fixes a bug where concurrent TDP MMU page faults can "corrupt" the unsync shadow page fields, notably unsync_children, as the TDP MMU holds mmu_lock for read and the unsync logic is not thread safe. Patch 2 is a tangentially related cleanup. Sean Christopherson (2): KVM: x86/mmu: Protect marking SPs unsync when using TDP MMU with spinlock KVM: x86/mmu: Drop 'shared' param from tdp_mmu_link_page() Documentation/virt/kvm/locking.rst | 8 +++---- arch/x86/include/asm/kvm_host.h | 3 +++ arch/x86/kvm/mmu/mmu.c | 36 ++++++++++++++++++++++++++++-- arch/x86/kvm/mmu/mmu_internal.h | 3 ++- arch/x86/kvm/mmu/spte.c | 4 ++-- arch/x86/kvm/mmu/spte.h | 2 +- arch/x86/kvm/mmu/tdp_mmu.c | 20 +++++------------ 7 files changed, 52 insertions(+), 24 deletions(-) -- 2.32.0.605.g8dce9f2422-goog