Re: [PATCH v4 1/2] f2fs: introduce proc/fs/f2fs/<dev>/fsck_stack node

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3037 bytes --]

Hi Yangtao,

I love your patch! Yet something to improve:

[auto build test ERROR on v5.14-rc5]
[cannot apply to f2fs/dev-test next-20210813]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Yangtao-Li/f2fs-introduce-proc-fs-f2fs-dev-fsck_stack-node/20210813-181512
base:    36a21d51725af2ce0700c6ebcb6b9594aac658a6
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/9170231cb55b00262ee1f9240b22b6f1b15bb1e1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Yangtao-Li/f2fs-introduce-proc-fs-f2fs-dev-fsck_stack-node/20210813-181512
        git checkout 9170231cb55b00262ee1f9240b22b6f1b15bb1e1
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from fs/f2fs/dir.c:13:
   fs/f2fs/f2fs.h: In function 'set_sbi_flag':
>> fs/f2fs/f2fs.h:1977:16: error: implicit declaration of function 'stack_trace_save'; did you mean 'stack_depot_save'? [-Werror=implicit-function-declaration]
    1977 |   nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 0);
         |                ^~~~~~~~~~~~~~~~
         |                stack_depot_save
   cc1: some warnings being treated as errors


vim +1977 fs/f2fs/f2fs.h

  1966	
  1967	static void set_sbi_flag(struct f2fs_sb_info *sbi, unsigned int type)
  1968	{
  1969		set_bit(type, &sbi->s_flag);
  1970	
  1971		if (unlikely(type ==  SBI_NEED_FSCK)) {
  1972			unsigned long entries[FSCK_STACK_DEPTH];
  1973			depot_stack_handle_t stack, *new;
  1974			unsigned int nr_entries;
  1975			int i;
  1976	
> 1977			nr_entries = stack_trace_save(entries, ARRAY_SIZE(entries), 0);
  1978			nr_entries = filter_irq_stacks(entries, nr_entries);
  1979			stack = stack_depot_save(entries, nr_entries, GFP_KERNEL);
  1980			if (!stack)
  1981				return;
  1982	
  1983			/* Try to find an existing entry for this backtrace */
  1984			for (i = 0; i < sbi->fsck_count; i++)
  1985				if (sbi->fsck_stack[i] == stack)
  1986					return;
  1987	
  1988			new = krealloc(sbi->fsck_stack, (sbi->fsck_count + 1) *
  1989				       sizeof(*sbi->fsck_stack), GFP_KERNEL);
  1990			if (!new)
  1991				return;
  1992	
  1993			sbi->fsck_stack = new;
  1994			sbi->fsck_stack[sbi->fsck_count++] = stack;
  1995		}
  1996	}
  1997	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60682 bytes --]