From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D942CC4338F for ; Wed, 18 Aug 2021 19:36:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE81A610A3 for ; Wed, 18 Aug 2021 19:36:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233036AbhHRThd (ORCPT ); Wed, 18 Aug 2021 15:37:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:51120 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231743AbhHRTh2 (ORCPT ); Wed, 18 Aug 2021 15:37:28 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id A31966108D; Wed, 18 Aug 2021 19:36:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1629315412; bh=VSqULppL4HoKddIgJNCboD09FTRpJSRbKPm/5gbsthc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gENa2lgMl/VNZHbcDucJOwzGEOxtYDVzrpUg/IqgsRMYbnujq7SDfz0gSQuQqn4pP qMWKKZPlkJb1oWb64iM99u283/lmgiOxz4eW6KWVQZva1cIMKzB/uasJD4AmqT6wVx kqyo9crHowLbhmmjK/fFwQUza867huQczqxTNveE= Date: Wed, 18 Aug 2021 12:36:51 -0700 From: Andrew Morton To: Andy Shevchenko Cc: Yury Norov , linux-kernel@vger.kernel.org, Petr Mladek , Rasmus Villemoes , Sergey Senozhatsky , Stephen Rothwell , Steven Rostedt Subject: Re: [PATCH] lib/vsprintf: don't increment buf in bitmap_list_string Message-Id: <20210818123651.61e2dfb55aea3b8340ab10c6@linux-foundation.org> In-Reply-To: References: <20210817193735.269942-1-yury.norov@gmail.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 18 Aug 2021 12:17:18 +0300 Andy Shevchenko wrote: > On Tue, Aug 17, 2021 at 12:37:35PM -0700, Yury Norov wrote: > > Thanks! > > > Increment is confusing as the buf is overritten at the same line. > > > Fixes: b1c4af4d3d6b (vsprintf: rework bitmap_list_string) (next-20210817) > > Fixes tag has its special format. I don't think we need it here, just to ask > Andrew in comments that it needs to be folded. I'm assuming that Sergey will be handling this one?