From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Daniel Bristot de Oliveira <bristot@kernel.org>,
Kees Cook <keescook@chromium.org>,
Deepthi Dhulipalla <dedhul@microsoft.com>,
Carlos Cardenas <Carlos.Cardenas@microsoft.com>,
Beau Belgrave <beaub@microsoft.com>
Subject: [RFC][PATCH 0/2] tracefs/tracing: Remove "other" permission from tracefs
Date: Wed, 18 Aug 2021 11:24:49 -0400 [thread overview]
Message-ID: <20210818152449.512418563@goodmis.org> (raw)
Currently tracefs is mounted with just 0700, keeping anyone that is not root
from accessing it. But tracefs is like any other file system, where its
permissions can be modified via chmod, chgrp, chown commands. Admins can
change the permission of the file system for their own needs. Of course,
because tracefs is a pseudo file system, a reboot will remove any updates an
admin makes.
There really is no reason why any of the files in tracefs should allow any
permission for the "other" group. Thus, make it so that, by default, all the
files created in tracefs do not have any permission bits set for other. An
admin can still change it to allow other to have permission to access
tracefs, but then they get to own the fallout that creates.
Steven Rostedt (VMware) (2):
tracefs: Have tracefs directories not set OTH permission bits by default
tracing: Disable "other" permission bits in the tracefs files
----
fs/tracefs/inode.c | 3 +-
kernel/trace/ftrace.c | 23 +++++------
kernel/trace/trace.c | 73 ++++++++++++++++++-----------------
kernel/trace/trace.h | 3 ++
kernel/trace/trace_dynevent.c | 2 +-
kernel/trace/trace_events.c | 42 ++++++++++----------
kernel/trace/trace_events_synth.c | 4 +-
kernel/trace/trace_functions_graph.c | 2 +-
kernel/trace/trace_hwlat.c | 6 +--
kernel/trace/trace_kprobe.c | 8 ++--
kernel/trace/trace_osnoise.c | 14 +++----
kernel/trace/trace_printk.c | 2 +-
kernel/trace/trace_recursion_record.c | 4 +-
kernel/trace/trace_stack.c | 6 +--
kernel/trace/trace_stat.c | 6 +--
kernel/trace/trace_uprobe.c | 4 +-
16 files changed, 105 insertions(+), 97 deletions(-)
next reply other threads:[~2021-08-18 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 15:24 Steven Rostedt [this message]
2021-08-18 15:24 ` [RFC][PATCH 1/2] tracefs: Have tracefs directories not set OTH permission bits by default Steven Rostedt
2021-08-18 15:24 ` [RFC][PATCH 2/2] tracing: Disable "other" permission bits in the tracefs files Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818152449.512418563@goodmis.org \
--to=rostedt@goodmis.org \
--cc=Carlos.Cardenas@microsoft.com \
--cc=akpm@linux-foundation.org \
--cc=beaub@microsoft.com \
--cc=bristot@kernel.org \
--cc=dedhul@microsoft.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome