From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Biggers <ebiggers@google.com>,
Eric Biggers <ebiggers@kernel.org>,
Gilad Ben-Yossef <gilad@benyossef.com>,
Ard Biesheuvel <ardb@kernel.org>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Jia Zhang <zhang.jia@linux.alibaba.com>,
"YiLin . Li" <YiLin.Li@linux.alibaba.com>
Subject: Re: [PATCH v2 0/3] support test GCM/CCM mode for SM4
Date: Sat, 21 Aug 2021 15:50:17 +0800 [thread overview]
Message-ID: <20210821075017.GE3392@gondor.apana.org.au> (raw)
In-Reply-To: <20210813075508.98854-1-tianjia.zhang@linux.alibaba.com>
On Fri, Aug 13, 2021 at 03:55:05PM +0800, Tianjia Zhang wrote:
> The GCM/CCM mode of SM4 is defined in the RFC 8998 specification:
> https://datatracker.ietf.org/doc/html/rfc8998
>
> There are several places where the return value check of crypto_aead_setkey
> and crypto_aead_setauthsize were lost. It is necessary to add these checks.
>
> At the same time, move the crypto_aead_setauthsize() call out of the loop,
> and only need to call it once after load transform.
>
> ---
> v2 changes:
> - check the crypto_aead_setauthsize() return value
> - move crypto_aead_setauthsize out of loop
> - update commit message
>
> Tianjia Zhang (3):
> crypto: tcrypt - Fix missing return value check
> crypto: testmgr - Add GCM/CCM mode test of SM4 algorithm
> crypto: tcrypt: add GCM/CCM mode test for SM4 algorithm
>
> crypto/tcrypt.c | 74 ++++++++++++++++++++----
> crypto/testmgr.c | 29 ++++++++++
> crypto/testmgr.h | 148 +++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 241 insertions(+), 10 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2021-08-21 7:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 7:55 Tianjia Zhang
2021-08-13 7:55 ` [PATCH v2 1/3] crypto: tcrypt - Fix missing return value check Tianjia Zhang
2021-08-13 9:03 ` Vitaly Chikunov
2021-08-13 7:55 ` [PATCH v2 2/3] crypto: testmgr - Add GCM/CCM mode test of SM4 algorithm Tianjia Zhang
2021-08-13 7:55 ` [PATCH v2 3/3] crypto: tcrypt: add GCM/CCM mode test for " Tianjia Zhang
2021-08-21 7:50 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210821075017.GE3392@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=YiLin.Li@linux.alibaba.com \
--cc=ardb@kernel.org \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=ebiggers@kernel.org \
--cc=gilad@benyossef.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tianjia.zhang@linux.alibaba.com \
--cc=zhang.jia@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®