From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE8F6C432BE for ; Sat, 21 Aug 2021 19:20:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA61F61214 for ; Sat, 21 Aug 2021 19:20:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230122AbhHUTVG (ORCPT ); Sat, 21 Aug 2021 15:21:06 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:24212 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229914AbhHUTVE (ORCPT ); Sat, 21 Aug 2021 15:21:04 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1629573625; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=a/CGSa13ltQ0+VJXtsPJ4pMzrIAABHKl6f/JaLvluu4=; b=fvBOt6NqecH8BZE4A+YP8YYg0ZiIXz/qmM9oyCAyoXI8O4vbCnQMYiCzwtIY/hMVzLLWK9I0 KSW0JE3NRZdOrLMTe6Pw6FyBNdxp/XngqAUDzSiU8vO2uWQaerBEPkWL6mwBGKb89BHqVVz3 ggfhr2xKlFroan07KefqEda8z2c= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-west-2.postgun.com with SMTP id 612151e7f588e42af19bb406 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 21 Aug 2021 19:20:07 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id A2C21C4360C; Sat, 21 Aug 2021 19:20:07 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5E08DC4338F; Sat, 21 Aug 2021 19:20:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 5E08DC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v4] rtw88: Remove unnecessary check code From: Kalle Valo In-Reply-To: <20210731163546.10753-1-len.baker@gmx.com> References: <20210731163546.10753-1-len.baker@gmx.com> To: Len Baker Cc: Yan-Hsuan Chuang , "David S. Miller" , Jakub Kicinski , Len Baker , Greg KH , Brian Norris , Pkshih , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210821192007.A2C21C4360C@smtp.codeaurora.org> Date: Sat, 21 Aug 2021 19:20:07 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Len Baker wrote: > The rtw_pci_init_rx_ring function is only ever called with a fixed > constant or RTK_MAX_RX_DESC_NUM for the "len" argument. Since this > constant is defined as 512, the "if (len > TRX_BD_IDX_MASK)" check > can never happen (TRX_BD_IDX_MASK is defined as GENMASK(11, 0) or in > other words as 4095). > > So, remove this check. > > The true motivation for this patch is to silence a false Coverity > warning. > > Reviewed-by: Brian Norris > Signed-off-by: Len Baker Patch applied to wireless-drivers-next.git, thanks. d816ce8744db rtw88: Remove unnecessary check code -- https://patchwork.kernel.org/project/linux-wireless/patch/20210731163546.10753-1-len.baker@gmx.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches