From: Bryan Brattlof <hello@bryanbrattlof.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Bryan Brattlof <hello@bryanbrattlof.com>
Subject: [PATCH v2 1/5] staging: rtl8723bs: remove sdio_write_mem()
Date: Sun, 22 Aug 2021 20:43:12 +0000 [thread overview]
Message-ID: <20210822204212.2832397-2-hello@bryanbrattlof.com> (raw)
In-Reply-To: <20210822204212.2832397-1-hello@bryanbrattlof.com>
The sdio_write_mem() function is unused in the driver. We can remove it.
Signed-off-by: Bryan Brattlof <hello@bryanbrattlof.com>
---
drivers/staging/rtl8723bs/hal/sdio_ops.c | 11 -----------
drivers/staging/rtl8723bs/include/rtw_io.h | 1 -
2 files changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
index a545832a468e..b784a390c8e1 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
@@ -356,16 +356,6 @@ static void sdio_read_mem(
sdio_readN(intfhdl, addr, cnt, rmem);
}
-static void sdio_write_mem(
- struct intf_hdl *intfhdl,
- u32 addr,
- u32 cnt,
- u8 *wmem
-)
-{
- sdio_writeN(intfhdl, addr, cnt, wmem);
-}
-
/*
* Description:
*Read from RX FIFO
@@ -474,7 +464,6 @@ void sdio_set_intf_ops(struct adapter *adapter, struct _io_ops *ops)
ops->_write16 = &sdio_write16;
ops->_write32 = &sdio_write32;
ops->_writeN = &sdio_writeN;
- ops->_write_mem = &sdio_write_mem;
ops->_write_port = &sdio_write_port;
}
diff --git a/drivers/staging/rtl8723bs/include/rtw_io.h b/drivers/staging/rtl8723bs/include/rtw_io.h
index e98083a07a66..87f36b7e880f 100644
--- a/drivers/staging/rtl8723bs/include/rtw_io.h
+++ b/drivers/staging/rtl8723bs/include/rtw_io.h
@@ -91,7 +91,6 @@ struct _io_ops {
int (*_write32_async)(struct intf_hdl *pintfhdl, u32 addr, u32 val);
void (*_read_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
- void (*_write_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
void (*_sync_irp_protocol_rw)(struct io_queue *pio_q);
--
2.30.2
next prev parent reply other threads:[~2021-08-22 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-22 20:42 [PATCH v2 0/5] staging: rtl8723bs: remove unused functions Bryan Brattlof
2021-08-22 20:43 ` Bryan Brattlof [this message]
2021-08-22 20:43 ` [PATCH v2 2/5] staging: rtl8723bs: remove sdio_writeN() Bryan Brattlof
2021-08-26 10:04 ` [PATCH v2 0/5] staging: rtl8723bs: remove unused functions Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210822204212.2832397-2-hello@bryanbrattlof.com \
--to=hello@bryanbrattlof.com \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®