From: Christoph Hellwig <hch@lst.de>
To: Joel Becker <jlbec@evilplan.org>
Cc: Sishuai Gong <sishuai@purdue.edu>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH 2/4] configfs: simplify the configfs_dirent_is_ready
Date: Wed, 25 Aug 2021 08:49:04 +0200 [thread overview]
Message-ID: <20210825064906.1694233-3-hch@lst.de> (raw)
In-Reply-To: <20210825064906.1694233-1-hch@lst.de>
Return the error directly instead of using a goto.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/configfs/dir.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/configfs/dir.c b/fs/configfs/dir.c
index cf08bbde55f3..5d58569f0eea 100644
--- a/fs/configfs/dir.c
+++ b/fs/configfs/dir.c
@@ -467,9 +467,8 @@ static struct dentry * configfs_lookup(struct inode *dir,
* not complete their initialization, since the dentries of the
* attributes won't be instantiated.
*/
- err = -ENOENT;
if (!configfs_dirent_is_ready(parent_sd))
- goto out;
+ return ERR_PTR(-ENOENT);
list_for_each_entry(sd, &parent_sd->s_children, s_sibling) {
if (sd->s_type & CONFIGFS_NOT_PINNED) {
@@ -493,7 +492,6 @@ static struct dentry * configfs_lookup(struct inode *dir,
return NULL;
}
-out:
return ERR_PTR(err);
}
--
2.30.2
next prev parent reply other threads:[~2021-08-25 6:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 6:49 configfs lookup race fix Christoph Hellwig
2021-08-25 6:49 ` [PATCH 1/4] configfs: return -ENAMETOOLONG earlier in configfs_lookup Christoph Hellwig
2021-08-31 5:50 ` Joel Becker
2021-08-31 5:52 ` Joel Becker
2021-08-25 6:49 ` Christoph Hellwig [this message]
2021-08-31 5:51 ` [PATCH 2/4] configfs: simplify the configfs_dirent_is_ready Joel Becker
2021-08-25 6:49 ` [PATCH 3/4] configfs: fold configfs_attach_attr into configfs_lookup Christoph Hellwig
2021-08-31 5:52 ` Joel Becker
2021-08-25 6:49 ` [PATCH 4/4] configfs: fix a race in configfs_lookup() Christoph Hellwig
2021-08-31 5:53 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825064906.1694233-3-hch@lst.de \
--to=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sishuai@purdue.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®