From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 990EEC4338F for ; Wed, 25 Aug 2021 10:05:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FC2B61178 for ; Wed, 25 Aug 2021 10:05:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239515AbhHYKFy (ORCPT ); Wed, 25 Aug 2021 06:05:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:60018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235904AbhHYKFv (ORCPT ); Wed, 25 Aug 2021 06:05:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E4AAD61076; Wed, 25 Aug 2021 10:05:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629885905; bh=YwYi8a+J5g/Nx04R5c0CB3jA7B0h8kMs+HlDvPDVe0Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DFnIqZ8e8yIcCuy2Hva0GCFyaX6/EN7I7TK1ec81fOPW/82dy8Y4PZfzSxWhLYCe9 bjPIoaIoFgyFv7YcdzhrNorwjNHUbZOqQWqn27qH+0Qtvu0hCLiGNwH0lfmfo+knt1 i8xjNAVYbsXS3UsNFOwOY3gnLkvurGeV7ahN4r9rghXj5f8dD0dZAD1PN3lxsPyzIo fuvtdDdBhBfRQBNCS+2NfJK2mEY14E+75km1SzGtL+iypEnaMPL+sAgp3R76XF+14F nBWwv13r8x5ymKB9m4PURqayrmvu1Ko6sBxPRlYIBVFoZfSRz+uWKr91xt+TF3h5pI NRPmQod1w3HKg== Date: Wed, 25 Aug 2021 11:05:01 +0100 From: Will Deacon To: Yajun Deng Cc: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lorenzo.pieralisi@arm.com Subject: Re: [PATCH linux-next] arm64: PCI: Introduce pcibios_free_irq() helper function Message-ID: <20210825100500.GC24546@willie-the-truck> References: <20210825071612.21543-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210825071612.21543-1-yajun.deng@linux.dev> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [+Lorenzo] On Wed, Aug 25, 2021 at 03:16:12PM +0800, Yajun Deng wrote: > Introduce pcibios_free_irq() to free irq in pci_device_probe() and > pci_device_remove() that in drivers/pci/pci-driver.c. Please can you describe the problem you're solving? > Signed-off-by: Yajun Deng > --- > arch/arm64/kernel/pci.c | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c > index 1006ed2d7c60..40da5aff4548 100644 > --- a/arch/arm64/kernel/pci.c > +++ b/arch/arm64/kernel/pci.c > @@ -25,10 +25,18 @@ > int pcibios_alloc_irq(struct pci_dev *dev) > { > if (!acpi_disabled) > - acpi_pci_irq_enable(dev); > + return acpi_pci_irq_enable(dev); This means we'll now fail device probe if we can't enable the GSI. Is that a problem? Will