From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HK_RANDOM_FROM,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0C04C432BE for ; Thu, 26 Aug 2021 10:20:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7BBF60E52 for ; Thu, 26 Aug 2021 10:20:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241360AbhHZKUu (ORCPT ); Thu, 26 Aug 2021 06:20:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234124AbhHZKUt (ORCPT ); Thu, 26 Aug 2021 06:20:49 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54064C061757 for ; Thu, 26 Aug 2021 03:20:02 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id x11so5256562ejv.0 for ; Thu, 26 Aug 2021 03:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+kvaMj8EJUxo9/2klnChfd6kwIC9S45AjjV1Kjn+v+M=; b=gAk75JrC/Yt1l+MhZuQc/J2oYzOViLo/QAADrmHo15V1YaWMk+idGOEKoU/jD6EBJv iQblaavqqvZxCkAA45XOp1aHLeam5O/JTPPh5WXlL6uPp1TkaWTnQOJvHNTgzl/yiwSt /oz2HVmua6gzRXonqy/G9FIU2F5/aGLjYKfEAfOYCUvx9qEmwZBKuWF8fNnKc9S5Wjfc h9jCwHfWwRcllF3OJCC53Jj26H9HDmoX7kpS/AQOdrH2Cv8TzKnT7Ie21T84qkR5kVZI TQxuqH7W+eRuQbyhZE6oamLqcwoe585pI4VlB7TOawHOYUeyviyMM8EmLgX2XphmjW1x m8bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+kvaMj8EJUxo9/2klnChfd6kwIC9S45AjjV1Kjn+v+M=; b=e29YhfunA2OumH6r1Vw+VFVDOf9GQUzSRQwwOqPtMuTcNEv12zMhb+hA7YT5HqzBQE B6MbNSWXCMhbQjaZGff+mGXpaUGpKt46dBtVbjRyNVhj2LOIHZLXb5e1hNth2Ep//uw1 nOXYDcS7fGylmC/Pw2XUnUvRbzFdJVAcdQD9cHu3jTKDYgCLY+sFi7zOlI1utlnFr5ee QBSI3m2QAYOC5u96zAOKxFBU0aEmtRQZiWnqrVI5NW0G/hQOYF+hRQSFjVhXUzklr+ci bQvAPCDtB19giBKfSjfyb2xFfIOzY5P638Y8QoiHU4xNI/ZNaPoGBiF2ZowjMia/6ySr I1lQ== X-Gm-Message-State: AOAM531iu4zAg+SfGtcMQgXNq7Fmfz0iw7co/klvhUGPIjzCCP31AsgM D7fE87zzXYelYLKbLfuME3HsORD1XgA= X-Google-Smtp-Source: ABdhPJy6tGk/bfd8yr0ySl3vhr3cNdZliifKQEN1W2EIwz+Wu2Q/n1qplHX3ymzoYdEJAcq1SC6o+Q== X-Received: by 2002:a17:906:4943:: with SMTP id f3mr3442697ejt.102.1629973200918; Thu, 26 Aug 2021 03:20:00 -0700 (PDT) Received: from agape.jhs ([5.171.81.205]) by smtp.gmail.com with ESMTPSA id k3sm1095440eje.117.2021.08.26.03.19.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 03:20:00 -0700 (PDT) Date: Thu, 26 Aug 2021 12:19:57 +0200 From: Fabio Aiuto To: "Fabio M. De Francesco" Cc: gregkh@linuxfoundation.org, Larry.Finger@lwfinger.net, phil@philpotter.co.uk, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: r8188eu: Provide a TODO file for this driver Message-ID: <20210826101956.GB1416@agape.jhs> References: <20210826014959.26857-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210826014959.26857-1-fmdefrancesco@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Fabio, On Thu, Aug 26, 2021 at 03:49:59AM +0200, Fabio M. De Francesco wrote: > Provide a TODO file that lists the tasks that should be carried out in > order to move this driver off drivers/staging. > > Signed-off-by: Fabio M. De Francesco > --- > > Thanks to Phillip Potter for for providing the first draft. > > drivers/staging/r8188eu/TODO | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > create mode 100644 drivers/staging/r8188eu/TODO > > diff --git a/drivers/staging/r8188eu/TODO b/drivers/staging/r8188eu/TODO > new file mode 100644 > index 000000000000..4bccca69abac > --- /dev/null > +++ b/drivers/staging/r8188eu/TODO > @@ -0,0 +1,16 @@ > +To-do list: > + > +* Correct the coding style according to Linux guidelines; please read the document > +at https://www.kernel.org/doc/html/latest/process/coding-style.html. > +* Remove unnecessary debugging/printing macros; for those that are still needed > +use the proper kernel API (pr_debug(), dev_dbg(), netdev_dbg()). > +* Remove dead code such as unusued functions, variables, fields, etc.. > +* Use in-kernel API and remove unnecessary wrappers where possible. > +* Remove the HAL layer and migrate its functionality into the relevant parts of > +the driver. > +* Switch to use LIB80211 (This work is currently in development by Larry Finger). > +* Switch to use MAC80211 (This work is currently in development by Larry Finger). Maybe I'm wrong but I think Larry is working on cfg80211 not exactly with lib80211 or mac80211. So I'd remove the clauses on parentheses. > + > +Please send any patches to Greg Kroah-Hartman , > +Larry Finger , Phillip Potter > +and CC linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org. > -- > 2.32.0 > > thank you, fabio