From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F4F7C4320A for ; Sun, 29 Aug 2021 11:36:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E24260F38 for ; Sun, 29 Aug 2021 11:36:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235236AbhH2Lhr (ORCPT ); Sun, 29 Aug 2021 07:37:47 -0400 Received: from elvis.franken.de ([193.175.24.41]:54442 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235143AbhH2Lhn (ORCPT ); Sun, 29 Aug 2021 07:37:43 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1mKJ7I-0006Zi-01; Sun, 29 Aug 2021 13:36:48 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id 62BD9C08FD; Sun, 29 Aug 2021 13:36:22 +0200 (CEST) Date: Sun, 29 Aug 2021 13:36:22 +0200 From: Thomas Bogendoerfer To: CGEL Cc: Aleksandar Markovic , linux-mips@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Jing Yangyang , Zeal Robot Subject: Re: [PATCH linux-next] mips:mmu: fix boolreturn.cocci warnings Message-ID: <20210829113622.GB4573@alpha.franken.de> References: <20210824063004.59604-1-deng.changcheng@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210824063004.59604-1-deng.changcheng@zte.com.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 23, 2021 at 11:30:04PM -0700, CGEL wrote: > From: Jing Yangyang > > ./arch/mips/kvm/mmu.c:489:9-10:WARNING: return of 0/1 in function > 'kvm_test_age_gfn' with return type bool > ./arch/mips/kvm/mmu.c:445:8-9 WARNING: return of 0/1 in function > 'kvm_unmap_gfn_range' with return type bool > > Return statements in functions returning bool should use true/false > instead of 1/0. > > Generated by: scripts/coccinelle/misc/boolreturn.cocci > > Reported-by: Zeal Robot > Signed-off-by: Jing Yangyang > --- > arch/mips/kvm/mmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/mips/kvm/mmu.c b/arch/mips/kvm/mmu.c > index 6d1f68c..1bfd1b5 100644 > --- a/arch/mips/kvm/mmu.c > +++ b/arch/mips/kvm/mmu.c > @@ -442,7 +442,7 @@ static int kvm_mips_mkold_gpa_pt(struct kvm *kvm, gfn_t start_gfn, > bool kvm_unmap_gfn_range(struct kvm *kvm, struct kvm_gfn_range *range) > { > kvm_mips_flush_gpa_pt(kvm, range->start, range->end); > - return 1; > + return true; > } > > bool kvm_set_spte_gfn(struct kvm *kvm, struct kvm_gfn_range *range) > @@ -486,7 +486,7 @@ bool kvm_test_age_gfn(struct kvm *kvm, struct kvm_gfn_range *range) > pte_t *gpa_pte = kvm_mips_pte_for_gpa(kvm, NULL, gpa); > > if (!gpa_pte) > - return 0; > + return false; > return pte_young(*gpa_pte); this is already "fixed" in mips-next by 126b39368604 MIPS: Return true/false (not 1/0) from bool functions Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]