From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53770C432BE for ; Sun, 29 Aug 2021 16:49:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C7AF60F38 for ; Sun, 29 Aug 2021 16:49:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235713AbhH2Quf (ORCPT ); Sun, 29 Aug 2021 12:50:35 -0400 Received: from mail-40136.protonmail.ch ([185.70.40.136]:19311 "EHLO mail-40136.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229692AbhH2Que (ORCPT ); Sun, 29 Aug 2021 12:50:34 -0400 Date: Sun, 29 Aug 2021 16:49:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bryanbrattlof.com; s=protonmail; t=1630255780; bh=2ff+10G4Dt6XXoNpjZ+1qlAIxYbBmewJrQRU+zrTaMM=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=ds5M/OHkjvRmXC+YKe3MbnlIvxCbNG/SyqbVp7UmhAc5iTIdfHl6sguKo+1p/fu8w JXYlMZRVcjcjk68IhLoxf8uVZR2m5UQ4N+PXnSC2UHcE1YHDlkZZmhOtkZxfunF1go 3ax48pTGL2F2WhtscwoyEx/koTs+TE0rg4Jo1C5BfQLkIRNRPC918Ewbg+i/qEJgYT mO4U6H4wNytuS8QFqLm0irovV6fOB10Z0SGaOIjG7FeYHJDWG7jTreHFVKZeJ59qg3 OhuWJFWwIey5Wk7exoSh2KmTlzm+8ZnHJjUlqAObP/KcSDd6oDE8bTVXsIHhmwza0S 0t2z6jco/pWHA== To: Krish Jain From: Bryan Brattlof Cc: Greg KH , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Reply-To: Bryan Brattlof Subject: Re: [PATCH] Declare the file_operations struct as const Message-ID: <20210829164921.u5ntqk5jz2v3hlgr@h510> In-Reply-To: References: <20210829144531.c2syu4vv4s22dlg7@h510> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On this day, August 29, 2021, thus sayeth Krish Jain: > > > > > > Hi, what option do you mean? I already ran make allmodconfig and sud= o > > > make modules_install install and then make "CCFLAGS=3D-Werror W=3D1 > > > M=3Ddrivers/staging/android/" and now I do get output but one line > > > "WARNING: Symbol version dump "Module.symvers" is missing. Modules ma= y > > > not have dependencies or modversions. You may get many unresolved > > > symbol warnings." . Then I tried "make CCFLAGS=3D-Werror V=3D1 > > > M=3Ddrivers/staging/android/" and that outputted the following: > > > > > > > Most of the answers you're asking for are going to get vague responses > > (if any) on the mailing lists. The idea being (and I agree with) that > > giving out the answers will steal your opportunity to explore and learn > > the material yourself. > > > > Yes, it would be faster if we told you the answer, but ultimately, we > > would be doing a disservice to you. > > > > Besides, more times than not we (me especially) don't have the answer. > > > > With that said, I will give a (generous) hint. :) > > > > Hi. Do I have to build the kernel once before this works? Or can I > just build a module directly? > Again, do not allow others to rob you of learning how to solve these issues yourself. I *strongly* encourage you to familiarize yourself with the Kernel Build System in the Documentation. https://www.kernel.org/doc/html/latest/kbuild/modules.html Specifically the first paragraph of "2. How to Build External Modules" It may seem like a lot for such a simple issue but it *is* worth it. ~Bryan