From: Wang Jianchao <jianchao.wan9@gmail.com>
To: tytso@mit.edu, adilger.kernel@dilger.ca
Cc: jack@suse.cz, guoqing.jiang@linux.dev,
linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org
Subject: [PATCH V4 3/5] ext4: remove the repeated comment of ext4_trim_all_free
Date: Mon, 30 Aug 2021 15:52:44 +0800 [thread overview]
Message-ID: <20210830075246.12516-4-jianchao.wan9@gmail.com> (raw)
In-Reply-To: <20210830075246.12516-1-jianchao.wan9@gmail.com>
From: Wang Jianchao <wangjianchao@kuaishou.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Wang Jianchao <wangjianchao@kuaishou.com>
---
fs/ext4/mballoc.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index e47089cc6c07..ef2aa2b1a939 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -6274,15 +6274,10 @@ static int ext4_try_to_trim_range(struct super_block *sb,
* @max: last group block to examine
* @minblocks: minimum extent block count
*
- * ext4_trim_all_free walks through group's buddy bitmap searching for free
- * extents. When the free block is found, ext4_trim_extent is called to TRIM
- * the extent.
- *
- *
* ext4_trim_all_free walks through group's block bitmap searching for free
* extents. When the free extent is found, mark it as used in group buddy
* bitmap. Then issue a TRIM command on this extent and free the extent in
- * the group buddy bitmap. This is done until whole group is scanned.
+ * the group buddy bitmap.
*/
static ext4_grpblk_t
ext4_trim_all_free(struct super_block *sb, ext4_group_t group,
--
2.17.1
next prev parent reply other threads:[~2021-08-30 7:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 7:52 [PATCH V4 0/5] ext4: get discard out of jbd2 commit kthread Wang Jianchao
2021-08-30 7:52 ` [PATCH V4 1/5] ext4: remove the 'group' parameter of ext4_trim_extent Wang Jianchao
2021-08-30 7:52 ` [PATCH V4 2/5] ext4: add new helper interface ext4_try_to_trim_range() Wang Jianchao
2021-08-30 7:52 ` Wang Jianchao [this message]
2021-08-30 7:52 ` [PATCH V4 4/5] ext4: get discard out of jbd2 commit kthread contex Wang Jianchao
2021-08-31 4:00 ` Theodore Ts'o
2021-08-30 7:52 ` [PATCH V4 5/5] ext4: flush background discard kwork when retry allocation Wang Jianchao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210830075246.12516-4-jianchao.wan9@gmail.com \
--to=jianchao.wan9@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=guoqing.jiang@linux.dev \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®