From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0751C432BE for ; Mon, 30 Aug 2021 15:50:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 99C8461029 for ; Mon, 30 Aug 2021 15:50:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237652AbhH3PvV (ORCPT ); Mon, 30 Aug 2021 11:51:21 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:60272 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231725AbhH3PvT (ORCPT ); Mon, 30 Aug 2021 11:51:19 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 74F81220D2; Mon, 30 Aug 2021 15:50:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1630338625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ceX1dMxIClr9YSJ/0dIk11Ssam9+xQ+XyrlF6BIEsAg=; b=AG5kyUwBn8ctqnX2+iI3inK6/Izq07j4SRmFwCUAszezt1MfHKA3kmRMqFkj+Ekmm+gv0x 8wf+zCSI5UOhyntCRY2tSlAMKxr++F8SgfO5HpD0/qzIT74mySuLyA8I+FxbzBbvaZJiHb uLjnhivX+znnreLH5KNzch5qWhng7MA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1630338625; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ceX1dMxIClr9YSJ/0dIk11Ssam9+xQ+XyrlF6BIEsAg=; b=ESJGojnzI4LchpjfkAqI6xi0wYJFsjXPCKieciALPDwamE+MsndawpN+SIqOgJwdJiPcqO G1Lxi2xjvjImGTBQ== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 5F61B139B8; Mon, 30 Aug 2021 15:50:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id +v/iFkH+LGFqGwAAGKfGzw (envelope-from ); Mon, 30 Aug 2021 15:50:25 +0000 Date: Mon, 30 Aug 2021 17:50:24 +0200 From: Daniel Wagner To: Sagi Grimberg Cc: linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Hannes Reinecke , yi.he@emc.com, kernel test robot Subject: Re: [PATCH v6] nvme-tcp: Do not reset transport on data digest errors Message-ID: <20210830155024.ekughhihfecbzzby@carbon.lan> References: <20210830133626.139828-1-dwagner@suse.de> <462c31ae-446b-cc23-eb91-5e27ef04ec13@grimberg.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <462c31ae-446b-cc23-eb91-5e27ef04ec13@grimberg.me> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 30, 2021 at 06:38:28PM +0300, Sagi Grimberg wrote: > > + if (req->status == cpu_to_le16(NVME_SC_SUCCESS)) > > endian conversion a zero enum? looks weird.. I though it makes sense to stay consistent with the rest and don't make it harder for the reader to figure out why this might not needed here. And obviously the fear of the static code analyzers... > But, > Reviewed-by: Sagi Grimberg Thanks!