From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9075EC432BE for ; Wed, 1 Sep 2021 04:42:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E95660BD3 for ; Wed, 1 Sep 2021 04:42:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241866AbhIAEng (ORCPT ); Wed, 1 Sep 2021 00:43:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241791AbhIAEnd (ORCPT ); Wed, 1 Sep 2021 00:43:33 -0400 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B38A5C061764 for ; Tue, 31 Aug 2021 21:42:37 -0700 (PDT) Received: by mail-pf1-x430.google.com with SMTP id 7so1049461pfl.10 for ; Tue, 31 Aug 2021 21:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=aqRbC7OOz0ApYRD7bkXLn6fuH45+VCn9w1jsepqRlwo=; b=rmYbuOxTZ+6f1mjLuKFFeXrXBEq+QAkPP1aN8DhuASGDG4MeFgKpJRvIT/d1WvZkw8 /YYMBKdBrUUuXhHKPj4yEFdLRPXmFZYZmmxAy+dZ/rkRhZFLEBjFU7QvXdGW8W8Hv3nx RBFHkE8ldm6CKEmHXxAMtmOCpR/38i4QmyqvEtzbTX3bh6cTVTcabJ6sUdTwptFKxhqc B/r/Rfx2mPPaAM9Ngv1pz4aBNWJ3Vy1cdVIJGUpVy2m783J7M4r9zORinvNj0wFRUM2i j+Z0QP99zMtU+S/APlD4UYvzjdMCibSiY0vX736A4lcESZpPRtcwbUDWPQ2DlPdf5nhy AlhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=aqRbC7OOz0ApYRD7bkXLn6fuH45+VCn9w1jsepqRlwo=; b=Av4gk/4r2mztdSkRF+vxvyzq3VnFL2sRi6j29jYLPn0/lofZ6GqdcRrKa0iipgWXoJ XUF1aYvvYGIrAevk6m1YTblKMpjofR+gvavPEtkKwoKS0XqoPAV9O8WbAvBwuflvdYkg oo/pzWzAF9iMNIM15YV9Rajs7wh0qLTiSp+Y0nRCR4nYBN45Zk6PCyFAm8zhcPwwQkh7 hRqCdyIUEL5CfsihMhTIdDLqKQxnDAH4+J9O6eknvbeNa4H2CB+ii7QZvrV1SlOd1hVF ErZRi3iQC56ebJp2Hx4BZeOE5ROg1H5uS9Tm7I5cTxtO+ZVWFpn4rl45lY3aKEbjJKbO UwQw== X-Gm-Message-State: AOAM530SVxlns29pbTlCN8lsmaapq9/RDV2eqa5D3LE1KS+67iX4U/bw PM1ycAIonZqeaL7+S7mdqDOsnQ== X-Google-Smtp-Source: ABdhPJxBLmO5TuD7amKUzz3cLmrbwBzUCWEtO7lH32rA7hSv3e5M0kUewmugYpzwLQwteyHfKDsIJQ== X-Received: by 2002:a62:cf86:0:b029:3e0:7cef:9e03 with SMTP id b128-20020a62cf860000b02903e07cef9e03mr32469702pfg.0.1630471357279; Tue, 31 Aug 2021 21:42:37 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id 31sm22105352pgy.26.2021.08.31.21.42.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Aug 2021 21:42:36 -0700 (PDT) Date: Wed, 1 Sep 2021 10:12:35 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Thierry Reding , Jonathan Hunter , Ulf Hansson , "Rafael J. Wysocki" , Kevin Hilman , Viresh Kumar , Stephen Boyd , Nishanth Menon , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH v10 2/8] opp: Allow dev_pm_opp_set_clkname() to replace released clock Message-ID: <20210901044235.2je35y3ajtctrall@vireshk-i7> References: <20210831135450.26070-1-digetx@gmail.com> <20210831135450.26070-3-digetx@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210831135450.26070-3-digetx@gmail.com> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31-08-21, 16:54, Dmitry Osipenko wrote: > The opp_table->clk is set to error once clock is released by > dev_pm_opp_put_clkname(). This doesn't allow to set clock again, I am not sure why are you required to set the clk again here ? I mean, users aren't expected to put clkname in the middle of using it. The set-name API also checks that the OPP list should be empty in such a case. > until OPP table is re-created from scratch. Check opp_table->clk > for both NULL and ERR_PTR to allow the clock's replacement. > > Signed-off-by: Dmitry Osipenko > --- > drivers/opp/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/opp/core.c b/drivers/opp/core.c > index dde8a5cc948c..602e502d092e 100644 > --- a/drivers/opp/core.c > +++ b/drivers/opp/core.c > @@ -2146,7 +2146,7 @@ struct opp_table *dev_pm_opp_set_clkname(struct device *dev, const char *name) > } > > /* clk shouldn't be initialized at this point */ > - if (WARN_ON(opp_table->clk)) { > + if (WARN_ON(!IS_ERR_OR_NULL(opp_table->clk))) { > ret = -EBUSY; > goto err; > } > -- > 2.32.0 -- viresh