From: Mark Brown <broonie@kernel.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Chen-Yu Tsai <wenst@chromium.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: core: resolve supply voltage deferral silently
Date: Wed, 1 Sep 2021 16:08:40 +0100 [thread overview]
Message-ID: <20210901150840.GF5976@sirena.org.uk> (raw)
In-Reply-To: <20210826124015.1.Iab79c6dd374ec48beac44be2fcddd165dd26476b@changeid>
[-- Attachment #1: Type: text/plain, Size: 619 bytes --]
On Thu, Aug 26, 2021 at 12:40:17PM -0700, Brian Norris wrote:
> if (current_uV < 0) {
> - rdev_err(rdev,
> - "failed to get the current voltage: %pe\n",
> - ERR_PTR(current_uV));
> + if (current_uV != -EPROBE_DEFER)
> + rdev_err(rdev,
> + "failed to get the current voltage: %pe\n",
> + ERR_PTR(current_uV));
This doesn't make sense to me. Why are we getting as far as trying to
read the voltage if we've been told to defer probe? This suggests that
we ought to be doing this earlier on. I see that the logic is already
there to handle a deferral being generated here but it looks off.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-01 15:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 19:40 Brian Norris
2021-09-01 15:08 ` Mark Brown [this message]
2021-09-01 20:06 ` Brian Norris
2021-09-02 4:09 ` Chen-Yu Tsai
2021-09-02 17:06 ` Mark Brown
2021-09-02 22:41 ` Brian Norris
2021-09-03 11:10 ` Mark Brown
2021-09-03 17:09 ` Brian Norris
2021-09-03 17:54 ` Mark Brown
2021-09-03 20:10 ` Brian Norris
2021-09-13 10:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210901150840.GF5976@sirena.org.uk \
--to=broonie@kernel.org \
--cc=briannorris@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®