From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B0B6C433F5 for ; Fri, 3 Sep 2021 20:30:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38886610A2 for ; Fri, 3 Sep 2021 20:30:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350646AbhICUbv (ORCPT ); Fri, 3 Sep 2021 16:31:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:50604 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350538AbhICUbu (ORCPT ); Fri, 3 Sep 2021 16:31:50 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 225FF610A1; Fri, 3 Sep 2021 20:30:49 +0000 (UTC) Date: Fri, 3 Sep 2021 16:30:47 -0400 From: Steven Rostedt To: Kalesh Singh Cc: surenb@google.com, hridya@google.com, gregkh@linuxfoundation.org, john.reitan@arm.com, orjan.eide@arm.com, mark.underwood@arm.com, gary.sweet@broadcom.com, stephen.mansfield@imgtec.com, kernel-team@android.com, Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: [RESEND v2] tracing/gpu: Add imported size to gpu_mem_imported tracepoint Message-ID: <20210903163047.20e4f286@gandalf.local.home> In-Reply-To: <20210831170233.1409537-1-kaleshsingh@google.com> References: <20210831170233.1409537-1-kaleshsingh@google.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 31 Aug 2021 17:02:29 +0000 Kalesh Singh wrote: > The existing gpu_mem_total tracepoint provides GPU drivers a uniform way > to report the per-process and system-wide GPU memory usage. This > tracepoint reports a single total of the GPU private allocations and the > imported memory. [1] > > To allow distinguishing GPU private vs imported memory, add an > imported_size field to the gpu_mem_total tracepoint. GPU drivers can use > this new field to report the per-process and global GPU-imported memory > in a uniform way. > > User space tools can detect and handle the old vs new gpu_mem_total > format via the gpu_mem/gpu_mem_total/format file. > > [1] https://lore.kernel.org/r/20200302234840.57188-1-zzyiwei@google.com/ > > Signed-off-by: Kalesh Singh > --- > include/trace/events/gpu_mem.h | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > This is that trace event that doesn't have any in tree callers, right? I thought there was going to be some soon. For the updates to the tracing side (besides not having any users), it looks trivial to me. Acked-by: Steven Rostedt (VMware) But this needs to be pulled in by one of the GPU maintainers. -- Steve