From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: kernel test robot <lkp@intel.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
MyungJoo Ham <myungjoo.ham@samsung.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: extcon-axp288: use low level P-Unit semaphore lock for axp288 register accesses
Date: Fri, 10 Sep 2021 09:13:54 +0200 [thread overview]
Message-ID: <20210910071354.GB1437@agape.jhs> (raw)
In-Reply-To: <3ecef801-7484-95ed-3e76-e7770146e626@redhat.com>
Hi Hans,
On Fri, Sep 10, 2021 at 09:03:42AM +0200, Hans de Goede wrote:
> Hi,
<snip>
> > ^
> > 6 errors generated.
>
> Ah yes, I should have caught this, we had the same issue with a similar patch to
> the axp288-fuel-gauge driver.
>
> The fix is this:
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index c69d40ae5619..aab87c9b35c8 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -23,7 +23,7 @@ config EXTCON_ADC_JACK
>
> config EXTCON_AXP288
> tristate "X-Power AXP288 EXTCON support"
> - depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI
> + depends on MFD_AXP20X && USB_SUPPORT && X86 && ACPI && IOSF_MBI
> select USB_ROLE_SWITCH
> help
> Say Y here to enable support for USB peripheral detection
>
> The new depends on is fine since all boards which use the AXP288 should
> always have IOSF_MBI enabled anyways.
>
> Fabio, can you send a v2 with this Kconfig change added please ?
>
> (and please also add my earlier Reviewed-by and Tested-by to the v2)
sure will fix and resend
>
>
> >
> >
thank you,
fabio
next prev parent reply other threads:[~2021-09-10 7:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 15:18 Fabio Aiuto
2021-09-09 16:20 ` Hans de Goede
2021-09-10 0:26 ` kernel test robot
2021-09-10 7:03 ` Hans de Goede
2021-09-10 7:13 ` Fabio Aiuto [this message]
2021-09-10 1:00 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910071354.GB1437@agape.jhs \
--to=fabioaiuto83@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=hdegoede@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®