From: Steffen Klassert <steffen.klassert@secunet.com>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<kuba@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<syzbot+b2be9dd8ca6f6c73ee2d@syzkaller.appspotmail.com>
Subject: Re: [PATCH] net: xfrm: fix shift-out-of-bounds in xfrm_get_default
Date: Fri, 10 Sep 2021 11:50:48 +0200 [thread overview]
Message-ID: <20210910095048.GL2319818@gauss3.secunet.de> (raw)
In-Reply-To: <20210902190400.5257-1-paskripkin@gmail.com>
On Thu, Sep 02, 2021 at 10:04:00PM +0300, Pavel Skripkin wrote:
> Syzbot hit shift-out-of-bounds in xfrm_get_default. The problem was in
> missing validation check for user data.
>
> up->dirmask comes from user-space, so we need to check if this value
> is less than XFRM_USERPOLICY_DIRMASK_MAX to avoid shift-out-of-bounds bugs.
>
> Fixes: 2d151d39073a ("xfrm: Add possibility to set the default to block if we have no policy")
> Reported-and-tested-by: syzbot+b2be9dd8ca6f6c73ee2d@syzkaller.appspotmail.com
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Applied, thanks Pavel!
prev parent reply other threads:[~2021-09-10 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 19:04 Pavel Skripkin
2021-09-10 9:50 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910095048.GL2319818@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=syzbot+b2be9dd8ca6f6c73ee2d@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®