From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00, DATE_IN_FUTURE_06_12,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2EB0C433F5 for ; Fri, 10 Sep 2021 08:23:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8853B610F8 for ; Fri, 10 Sep 2021 08:23:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231767AbhIJIYb (ORCPT ); Fri, 10 Sep 2021 04:24:31 -0400 Received: from mga05.intel.com ([192.55.52.43]:40633 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231750AbhIJIY2 (ORCPT ); Fri, 10 Sep 2021 04:24:28 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10102"; a="306592052" X-IronPort-AV: E=Sophos;i="5.85,282,1624345200"; d="scan'208";a="306592052" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2021 01:23:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,282,1624345200"; d="scan'208";a="504974445" Received: from kailun-nuc9i9qnx.sh.intel.com ([10.239.160.139]) by fmsmga008.fm.intel.com with ESMTP; 10 Sep 2021 01:23:12 -0700 From: Kailun Qin To: tj@kernel.org, bsegall@google.com, linux-kernel@vger.kernel.org Cc: cgroups@vger.kernel.org, changhuaixin@linux.alibaba.com, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, Kailun Qin Subject: [PATCH] sched/core: Fix wrong burst unit in cgroup2 cpu.max write Date: Fri, 10 Sep 2021 12:25:09 -0400 Message-Id: <20210910162509.622222-1-kailun.qin@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In cpu_max_write(), as the eventual tg_set_cfs_bandwidth() operates on the burst in nsec which is input from tg_get_cfs_burst() in usec, it should be converted into nsec accordingly. If not, this may cause a write into cgroup2 cpu.max to unexpectedly change an already set cpu.max.burst. This patch addresses the above issue. Signed-off-by: Kailun Qin --- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index c4462c454ab9..fc9fcc56149f 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -10711,7 +10711,7 @@ static ssize_t cpu_max_write(struct kernfs_open_file *of, { struct task_group *tg = css_tg(of_css(of)); u64 period = tg_get_cfs_period(tg); - u64 burst = tg_get_cfs_burst(tg); + u64 burst = (u64)tg_get_cfs_burst(tg) * NSEC_PER_USEC; u64 quota; int ret; -- 2.25.1