From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6753EC4332F for ; Fri, 10 Sep 2021 18:44:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4E83C6124D for ; Fri, 10 Sep 2021 18:44:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234053AbhIJSqH (ORCPT ); Fri, 10 Sep 2021 14:46:07 -0400 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]:33210 "EHLO smtp-relay-internal-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234187AbhIJSpg (ORCPT ); Fri, 10 Sep 2021 14:45:36 -0400 Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 25F444025E for ; Fri, 10 Sep 2021 18:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1631299458; bh=nEPszmF8/zXe3qLQaYBaJlARsp+rY7T/kVvjiAAAUv0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ZIZaUm/D8QGgJv2u0iIzucqWSUI3EaCTPZPfj/LwTF6fb7jJC2enrF+klf3W6kpDm t1GqM4d1lyEGfH/HpQywTy4/XoJJgEip5YPwTIzfAjOzpf3hWfavEI2CT3l78xVFC8 AJkr/Nkt2jziZezWYG0iPtPUbhMcpAQa6c8RXkdqAEJoF3kI1y7tjQ/qzlC8QAIf7r 2AQXTTthb5paymD9CroH5RRWGyYncU5CgLpfMMdlHY+l7T5Zfqh597YzX0WeTW8qX9 P9sgT4xTOXK5jB7LSCfx0EtHax7fD80iK+Yys5QaR9pzxo+M09RpDMskINqBMV6soU +kt+gMgeVroAA== Received: by mail-pf1-f197.google.com with SMTP id r206-20020a6276d7000000b004365c6064fbso1543755pfc.5 for ; Fri, 10 Sep 2021 11:44:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nEPszmF8/zXe3qLQaYBaJlARsp+rY7T/kVvjiAAAUv0=; b=z0wRLZyx04xSLuo8yMT4QjnjSIoR7yww8zPJFSIjiwMfQnE9II378jcJDwOcpPbHX6 n8JRwsDWOH8QX14bq3JMlbPVTihlpys2XfHOMThJomC5QW2rOIe+MjUrtoRlyB74aF80 ayg4XnygQwTwdcePl743ezCqk14oTqnZVw2JYEC5WK2NHP4tqm4bhrqGuBCW0wPNrfYo Rh393a7483kUwSoE9tUkh3KQeqg8BYUfXwn8VkAUoFmz3CHI+FLLQ1LPN0kBeRZXbIvV Tb7KaXJ2uzRYUa/D326sCkZKIHRUhD6miny4HqVOMlHZqWQnl5VN4+bTo4Wgcbzqk1pM P8Ag== X-Gm-Message-State: AOAM5328ds6JzhM3PIZ+XNEbbTzPp92AVw0iU+QDUxZwL5tdhE4aGPb1 LT9NeokFI1HYFG/fiaT0J/xNgyTmvvey0d1tLkfJPzw2VW7ReRLaj0NCb5gL0qDTLEzgt6AAJ3a AX+DKXkGEtk5crw330Y5iPm4ssUntPWnOnSCX+eXohA== X-Received: by 2002:a63:5413:: with SMTP id i19mr8424327pgb.297.1631299455509; Fri, 10 Sep 2021 11:44:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXjj3Yk32lc4YcAVf/xRrgaUwwzlhuAeY6FGYPYZ0U0NH1J6Yk5syropXrQifRah2xDEqUrA== X-Received: by 2002:a63:5413:: with SMTP id i19mr8424312pgb.297.1631299455191; Fri, 10 Sep 2021 11:44:15 -0700 (PDT) Received: from localhost.localdomain ([69.163.84.166]) by smtp.gmail.com with ESMTPSA id l1sm5438825pju.15.2021.09.10.11.44.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Sep 2021 11:44:14 -0700 (PDT) From: Tim Gardner To: x86@kernel.org Cc: tim.gardner@canonical.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Peter Zijlstra (Intel)" , Giovanni Gherdovich , "Rafael J. Wysocki" , Vitaly Kuznetsov , Alison Schofield , Nathan Fontenot , Balbir Singh , linux-kernel@vger.kernel.org Subject: [PATCH] x86/smp: Unused value freq_scale Date: Fri, 10 Sep 2021 12:44:05 -0600 Message-Id: <20210910184405.24422-1-tim.gardner@canonical.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Coverity warns of an unused value in arch_scale_freq_tick(). CID 100778 (#1 of 1): Unused value (UNUSED_VALUE) assigned_value: Assigning value 1024ULL to freq_scale here, but that stored value is overwritten before it can be used. e2b0d619b400a ("x86, sched: check for counters overflow in frequency invariant accounting") introduced this warning. Fix this by removing the variable initializer. Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: x86@kernel.org Cc: "H. Peter Anvin" Cc: "Peter Zijlstra (Intel)" Cc: Giovanni Gherdovich Cc: "Rafael J. Wysocki" Cc: Vitaly Kuznetsov Cc: Alison Schofield Cc: Nathan Fontenot Cc: Balbir Singh Cc: linux-kernel@vger.kernel.org Signed-off-by: Tim Gardner --- arch/x86/kernel/smpboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index 85f6e242b6b4..c453b825a57f 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -2166,7 +2166,7 @@ DEFINE_PER_CPU(unsigned long, arch_freq_scale) = SCHED_CAPACITY_SCALE; void arch_scale_freq_tick(void) { - u64 freq_scale = SCHED_CAPACITY_SCALE; + u64 freq_scale; u64 aperf, mperf; u64 acnt, mcnt; -- 2.33.0