From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE2F4C433F5 for ; Sat, 11 Sep 2021 13:13:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9428E6135F for ; Sat, 11 Sep 2021 13:13:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236364AbhIKNPB (ORCPT ); Sat, 11 Sep 2021 09:15:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:38164 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236348AbhIKNNn (ORCPT ); Sat, 11 Sep 2021 09:13:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 08210611BF; Sat, 11 Sep 2021 13:12:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631365950; bh=EFMNFVAc5CcSijdhhhVHCaxpm6yJnxx8kYaKNOizbCs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kBMp8Gx8eUongj6OpSwfLMKLKZ/Vlf/9JE+rtHXUhqURe7gBUY8smYocC3K9pSKca 4IdmfBinbUdwfNfr+IK6q3j1SowQlJZfQco2gjA8J8W9NrbcVqLlRqfM0IRvRyXQnC r81xMxtQ6TSslmDv+VbLhEnTqypbSD5E2o/ZO6wn8715crkbChGKu2DEkgWbZzh+Um xo/AwESeWa9kZVO8qIr7o1j5uGrgI75Hu8eb2b3Gt5BB4Zar46L7dMiyw8MFSQ2dOz rb3h6SuJD0Nw6keYLdpURDQZa2uS/ZClQGHbfFk44GF6clPlGhQ04FE5kG9Ul3p4xS 9LM8DqE5vETuA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: zhaoxiao , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.14 31/32] stmmac: dwmac-loongson:Fix missing return value Date: Sat, 11 Sep 2021 09:11:48 -0400 Message-Id: <20210911131149.284397-31-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210911131149.284397-1-sashal@kernel.org> References: <20210911131149.284397-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: zhaoxiao [ Upstream commit 5289de5929d1758a95477a4d160195397ccffa7b ] Add the return value when phy_mode < 0. Signed-off-by: zhaoxiao Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c index 4c9a37dd0d3f..ecf759ee1c9f 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c @@ -109,8 +109,10 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id plat->bus_id = pci_dev_id(pdev); phy_mode = device_get_phy_mode(&pdev->dev); - if (phy_mode < 0) + if (phy_mode < 0) { dev_err(&pdev->dev, "phy_mode not found\n"); + return phy_mode; + } plat->phy_interface = phy_mode; plat->interface = PHY_INTERFACE_MODE_GMII; -- 2.30.2