From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92E5BC433F5 for ; Sat, 11 Sep 2021 13:16:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7614F61152 for ; Sat, 11 Sep 2021 13:16:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237096AbhIKNSA (ORCPT ); Sat, 11 Sep 2021 09:18:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:38124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237027AbhIKNPi (ORCPT ); Sat, 11 Sep 2021 09:15:38 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 31B6461215; Sat, 11 Sep 2021 13:13:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631365990; bh=P8tuf+tDy2pcR8mAryvwRZSmAXGTiQWLnb3UXVnShc0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uZGyPAPUJAmMpSQZjGGSJD0ojrSpYtpcsacyfsSdyogo/X5EkcKIt91QKnxxAlabt uWZPHL2z37o0jPLerDeqHuYJ1NHAOh0klkfh4Z6WxUC1WMMmgwbPXs7cx3VLgBgxER fuhBDxAokcrK5aqiCE39fXsdmr4dbheaqNAG0D8mpSt2wJNehYW/1Co+cWGzaz2r4D v8mGIPvGKlwebpfiug71FcJ1wBd6ArXLBGoUB3tHnQFSv0EeOXDPLtri68QNLsNgHT BbzImgAtQFzpoVg3yK/M6ofqI/2DPbCN4sQ8uuJgQWeHs+pLqwjZNpMoGMs56V1Ud9 LWQXYff/m1guQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Li , Abaci Robot , Serge Semin , Jon Mason , Sasha Levin , linux-ntb@googlegroups.com Subject: [PATCH AUTOSEL 5.13 28/29] NTB: perf: Fix an error code in perf_setup_inbuf() Date: Sat, 11 Sep 2021 09:12:32 -0400 Message-Id: <20210911131233.284800-28-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210911131233.284800-1-sashal@kernel.org> References: <20210911131233.284800-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Li [ Upstream commit 0097ae5f7af5684f961a5f803ff7ad3e6f933668 ] When the function IS_ALIGNED() returns false, the value of ret is 0. So, we set ret to -EINVAL to indicate this error. Clean up smatch warning: drivers/ntb/test/ntb_perf.c:602 perf_setup_inbuf() warn: missing error code 'ret'. Reported-by: Abaci Robot Signed-off-by: Yang Li Reviewed-by: Serge Semin Signed-off-by: Jon Mason Signed-off-by: Sasha Levin --- drivers/ntb/test/ntb_perf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c index 89df1350fefd..65e1e5cf1b29 100644 --- a/drivers/ntb/test/ntb_perf.c +++ b/drivers/ntb/test/ntb_perf.c @@ -598,6 +598,7 @@ static int perf_setup_inbuf(struct perf_peer *peer) return -ENOMEM; } if (!IS_ALIGNED(peer->inbuf_xlat, xlat_align)) { + ret = -EINVAL; dev_err(&perf->ntb->dev, "Unaligned inbuf allocated\n"); goto err_free_inbuf; } -- 2.30.2