From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 050EDC433F5 for ; Sat, 11 Sep 2021 13:21:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E48F2611C3 for ; Sat, 11 Sep 2021 13:21:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237425AbhIKNWZ (ORCPT ); Sat, 11 Sep 2021 09:22:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:49040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237198AbhIKNTR (ORCPT ); Sat, 11 Sep 2021 09:19:17 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 62DBA6135E; Sat, 11 Sep 2021 13:14:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631366042; bh=U67OreaikvH+lcv14uvfEz8Sjs68iNs55ntpwLtf2aA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sXgfWvcl2Mp6+O026EzKBDQr2OKUHV/51QXREMb8aFpwukE69lnyLZEFE93jMglIS KMVxap5SAhEia6oCf5vkrWo/Z4hcT+AFXFP+j5jT8GRoZ6ffwBFiIy6uipOSLHX3Tc k9MzQWISfG0DpFzxmxkrfhW+tDFEOyYmjUvlepqdm6xNYmdX6Lya5JtAiF+w+HO/CS g1PW3aB/t6I2H7qvO0e4THNeoLj5I7rj7S2qwuIg7zixVU8ZRAdoSKYpaM64MEBexT Yo8PxwpsFesAN6nGBmkt2eEvvZnbsLZR64HBKk+132TA6ohVf4a7wVOL+KxGe1n3e+ TQHf+iZ9Bg7Ag== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yang Li , Abaci Robot , Logan Gunthorpe , Jon Mason , Sasha Levin , linux-ntb@googlegroups.com Subject: [PATCH AUTOSEL 5.4 13/14] NTB: Fix an error code in ntb_msit_probe() Date: Sat, 11 Sep 2021 09:13:44 -0400 Message-Id: <20210911131345.285564-13-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210911131345.285564-1-sashal@kernel.org> References: <20210911131345.285564-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Li [ Upstream commit 319f83ac98d7afaabab84ce5281a819a358b9895 ] When the value of nm->isr_ctx is false, the value of ret is 0. So, we set ret to -ENOMEM to indicate this error. Clean up smatch warning: drivers/ntb/test/ntb_msi_test.c:373 ntb_msit_probe() warn: missing error code 'ret'. Reported-by: Abaci Robot Signed-off-by: Yang Li Reviewed-by: Logan Gunthorpe Signed-off-by: Jon Mason Signed-off-by: Sasha Levin --- drivers/ntb/test/ntb_msi_test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/ntb/test/ntb_msi_test.c b/drivers/ntb/test/ntb_msi_test.c index 99d826ed9c34..662067dc9ce2 100644 --- a/drivers/ntb/test/ntb_msi_test.c +++ b/drivers/ntb/test/ntb_msi_test.c @@ -372,8 +372,10 @@ static int ntb_msit_probe(struct ntb_client *client, struct ntb_dev *ntb) if (ret) goto remove_dbgfs; - if (!nm->isr_ctx) + if (!nm->isr_ctx) { + ret = -ENOMEM; goto remove_dbgfs; + } ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO); -- 2.30.2