From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3E1AC433FE for ; Tue, 14 Sep 2021 22:45:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC26D60F8F for ; Tue, 14 Sep 2021 22:45:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235656AbhINWqs (ORCPT ); Tue, 14 Sep 2021 18:46:48 -0400 Received: from mail-0301.mail-europe.com ([188.165.51.139]:42257 "EHLO mail-0301.mail-europe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235313AbhINWqr (ORCPT ); Tue, 14 Sep 2021 18:46:47 -0400 Date: Tue, 14 Sep 2021 22:45:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bryanbrattlof.com; s=protonmail; t=1631659526; bh=NgZMqBOxNObodZSjMDIHyt0PNPZZdXFN2N/CqmntTFM=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=nhf3S8liJkAq1T/BDhESL1FtcJzciSfJQV4L+im0hX0emr+legpSumjsxDFPfdCeS w23Xuvq67qt++gt/7Av0d7Uuq7DY4UzWFn6eyGu/3ILjZtAep9Rt6jZBW3PZydmurv ATfPA86ccj00/ZcuEK5gS+lhq55BPqK7UynZ77QOVjadz/8pF27rS53nub9tfDtpcp Pov9QugSCgbjWU7OfyIRv+tYqkrEaYIWL4sppESlGsc/9Q0tZE/rc8eF5/MhqCIi4V R3ZFwAFFQojvX15I9DT4WMa2FU8x0wN3AnF1SNdEU2Tgit3tbi4vPiIoQT7amXy0CJ 9phZSSpiTrOIw== To: Dan Carpenter From: Bryan Brattlof Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Reply-To: Bryan Brattlof Subject: Re: [PATCH] staging: rtl8723bs: define wowlan_stub only when CONFIG_PM is enabled Message-ID: <20210914224509.g2fbttqmrjhevftu@h510> In-Reply-To: <20210914085214.GA2088@kadam> References: <20210913140937.1490133-1-hello@bryanbrattlof.com> <20210913234247.ptqjjbilrtkzc4id@h510> <20210914085214.GA2088@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On this day, September 14, 2021, thus sayeth Dan Carpenter: > On Mon, Sep 13, 2021 at 11:42:55PM +0000, Bryan Brattlof wrote: > > I'll be back with a v2 that rips all of this out. > > Or use the __maybe_unused annotation: > > static __maybe_unused const struct wiphy_wowlan_support wowlan_stub =3D { > Thanks for the suggestion Dan; I like this much better. :) I've been poking around with my config today and noticed I can still produce this warning with CONFIG_PM enabled, which means something else is going on that I don't fully understand yet. I may hold off on sending v2 until I make sure I understand what's going on and double check that I didn't bork my config. Thanks from jumping in ~Bryan