From: Ricardo Ribalda <ribalda@chromium.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
hn.chen@sunplusit.com
Cc: Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH 1/3] media: uvc: Extend documentation of uvc_video_clock_decode()
Date: Wed, 15 Sep 2021 22:05:23 +0200 [thread overview]
Message-ID: <20210915200525.448941-2-ribalda@chromium.org> (raw)
In-Reply-To: <20210915200525.448941-1-ribalda@chromium.org>
Make a explicit reference to uvc 1.5, explaining how the algorithm
supports the different behaviour of uvc 1.1 and 1.5.
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
---
drivers/media/usb/uvc/uvc_video.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
index e16464606b14..77f4090f27d2 100644
--- a/drivers/media/usb/uvc/uvc_video.c
+++ b/drivers/media/usb/uvc/uvc_video.c
@@ -505,6 +505,9 @@ uvc_video_clock_decode(struct uvc_streaming *stream, struct uvc_buffer *buf,
/* To limit the amount of data, drop SCRs with an SOF identical to the
* previous one.
+ * This filtering is also needed for supporting UVC 1.5. Where all the
+ * data packages of the same frame contains the same sof. In that case
+ * only the first one will match the host_sof.
*/
dev_sof = get_unaligned_le16(&data[header_size - 2]);
if (dev_sof == stream->clock.last_sof)
--
2.33.0.309.g3052b89438-goog
next prev parent reply other threads:[~2021-09-15 20:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 20:05 [PATCH 0/3] uvcvideo: Fix hw timestamp in Sunplus modules Ricardo Ribalda
2021-09-15 20:05 ` Ricardo Ribalda [this message]
2021-09-15 20:05 ` [PATCH 2/3] media: uvc: Allow quirking by entity guid Ricardo Ribalda
2021-09-15 20:05 ` [PATCH 3/3] media: uvc: Create UVC_QUIRK_IGNORE_EMPTY_TS quirk Ricardo Ribalda
2021-10-12 7:59 ` [PATCH 0/3] uvcvideo: Fix hw timestamp in Sunplus modules hn.chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915200525.448941-2-ribalda@chromium.org \
--to=ribalda@chromium.org \
--cc=hn.chen@sunplusit.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®