From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 303E6C433F5 for ; Fri, 17 Sep 2021 02:35:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 195FA611F2 for ; Fri, 17 Sep 2021 02:35:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242869AbhIQCgf (ORCPT ); Thu, 16 Sep 2021 22:36:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:33464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242821AbhIQCgC (ORCPT ); Thu, 16 Sep 2021 22:36:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 25E026113E; Fri, 17 Sep 2021 02:34:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631846080; bh=eVlCf9tNIsvO/ehpnl4cvb77fCAZUquM30wCN7BHxDg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pmEdpNrzvG5upTf/84I8WHaJy9yDP+ZyFi0VL6fnR55txT53C+vEaPGfYAf6fdeo5 VCJPCkpj4WZaxQba3UKtdXr2/EWNr8X8QX+yW0953m2c2PTqurNrQMLVMa8q0Mzg1b 7KJGgkEPppwITSxK9wRecIZj5NCm1AEraGv1LKln7Qt4Jl64ZlL9EQW/M/hFMX6gMP gXpACIFoiSHEo+fNLAMnbjJDPV9G8WCmSFxH3bdQrt3Ayglyi1jnxU7BqRTfA9dyMM x5xOMl0Tmuj2yUGsChwRuwCbM8AE9XLErLX/z+9GG5sjIecqc2vBARLY5opItuffBB kXOa/J5td4JcA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , Thierry Reding , Sasha Levin , lee.jones@linaro.org, linux-pwm@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 2/8] pwm: img: Don't modify HW state in .remove() callback Date: Thu, 16 Sep 2021 22:34:27 -0400 Message-Id: <20210917023437.816574-2-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210917023437.816574-1-sashal@kernel.org> References: <20210917023437.816574-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Uwe Kleine-König [ Upstream commit c68eb29c8e9067c08175dd0414f6984f236f719d ] A consumer is expected to disable a PWM before calling pwm_put(). And if they didn't there is hopefully a good reason (or the consumer needs fixing). Also if disabling an enabled PWM was the right thing to do, this should better be done in the framework instead of in each low level driver. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding Signed-off-by: Sasha Levin --- drivers/pwm/pwm-img.c | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/drivers/pwm/pwm-img.c b/drivers/pwm/pwm-img.c index 22c002e685b3..37f9b688661d 100644 --- a/drivers/pwm/pwm-img.c +++ b/drivers/pwm/pwm-img.c @@ -329,23 +329,7 @@ static int img_pwm_probe(struct platform_device *pdev) static int img_pwm_remove(struct platform_device *pdev) { struct img_pwm_chip *pwm_chip = platform_get_drvdata(pdev); - u32 val; - unsigned int i; - int ret; - - ret = pm_runtime_get_sync(&pdev->dev); - if (ret < 0) { - pm_runtime_put(&pdev->dev); - return ret; - } - - for (i = 0; i < pwm_chip->chip.npwm; i++) { - val = img_pwm_readl(pwm_chip, PWM_CTRL_CFG); - val &= ~BIT(i); - img_pwm_writel(pwm_chip, PWM_CTRL_CFG, val); - } - pm_runtime_put(&pdev->dev); pm_runtime_disable(&pdev->dev); if (!pm_runtime_status_suspended(&pdev->dev)) img_pwm_runtime_suspend(&pdev->dev); -- 2.30.2