From: Michal Kubecek <mkubecek@suse.cz>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-kernel@vger.kernel.org
Cc: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] nvmem: nintendo-otp: add dependency on CONFIG_HAS_IOMEM
Date: Fri, 17 Sep 2021 13:37:48 +0200 [thread overview]
Message-ID: <20210917113748.aula2xsiih5wsjdq@lion.mk-sys.cz> (raw)
In-Reply-To: <694766b15cfa3759e3686145417952d320029390.1631877302.git.mkubecek@suse.cz>
On Fri, Sep 17, 2021 at 01:20:18PM +0200, Michal Kubecek wrote:
> Function nintendo_otp_probe() calls devm_ioremap_resource() which is only
> available if CONFIG_HAS_IOMEM is enabled. Add a kconfig dependency like
> other similar drivers have.
>
> Fixes: 3683b761fe3a ("nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP")
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
A note: the build failure was already reported in
https://lore.kernel.org/all/202108250657.h5CWR7Xf-lkp@intel.com/
Michal
> ---
> drivers/nvmem/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig
> index 39854d43758b..fb4005df86c0 100644
> --- a/drivers/nvmem/Kconfig
> +++ b/drivers/nvmem/Kconfig
> @@ -108,6 +108,7 @@ config MTK_EFUSE
> will be called efuse-mtk.
>
> config NVMEM_NINTENDO_OTP
> + depends on HAS_IOMEM
> tristate "Nintendo Wii and Wii U OTP Support"
> help
> This is a driver exposing the OTP of a Nintendo Wii or Wii U console.
> --
> 2.33.0
>
prev parent reply other threads:[~2021-09-17 11:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-17 11:20 Michal Kubecek
2021-09-17 11:37 ` Michal Kubecek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210917113748.aula2xsiih5wsjdq@lion.mk-sys.cz \
--to=mkubecek@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=linkmauve@linkmauve.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®