From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ED43C433F5 for ; Sat, 18 Sep 2021 02:26:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43F46610D1 for ; Sat, 18 Sep 2021 02:26:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240744AbhIRC2O (ORCPT ); Fri, 17 Sep 2021 22:28:14 -0400 Received: from mx22.baidu.com ([220.181.50.185]:44824 "EHLO baidu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S236906AbhIRC2L (ORCPT ); Fri, 17 Sep 2021 22:28:11 -0400 Received: from BJHW-MAIL-EX04.internal.baidu.com (unknown [10.127.64.14]) by Forcepoint Email with ESMTPS id 3EDD9F079D5133A07D0D; Sat, 18 Sep 2021 10:26:37 +0800 (CST) Received: from BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) by BJHW-MAIL-EX04.internal.baidu.com (10.127.64.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Sat, 18 Sep 2021 10:26:37 +0800 Received: from localhost (172.31.63.8) by BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Sat, 18 Sep 2021 10:26:36 +0800 Date: Sat, 18 Sep 2021 10:26:36 +0800 From: Cai Huoqing To: Fabio Estevam CC: Dong Aisheng , Shawn Guo , Stefan Agner , Linus Walleij , open list: GPIO SUBSYSTEM , ; linux-kernel Illegal-Object: Syntax error in CC: address found on vger.kernel.org: CC: ;linux-kernel ^-missing semicolon to end mail group, extraneous tokens in mailbox, missing end of mailbox Subject: Re: [PATCH] pinctrl: freescale: Add helper dependency on COMPILE_TEST Message-ID: <20210918022636.GA18195@LAPTOP-UKSR4ENP.internal.baidu.com> References: <20210825082251.2484-1-caihuoqing@baidu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [172.31.63.8] X-ClientProxiedBy: BJHW-Mail-Ex01.internal.baidu.com (10.127.64.11) To BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17 9月 21 08:50:55, Fabio Estevam wrote: > Hi Cai, > > On Wed, Aug 25, 2021 at 5:23 AM Cai Huoqing wrote: > > > > it's helpful for complie test in other platform(e.g.X86) > > > > Signed-off-by: Cai Huoqing > > --- > > drivers/pinctrl/freescale/Kconfig | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig > > index 21fa21c6547b..defc1f38efc7 100644 > > --- a/drivers/pinctrl/freescale/Kconfig > > +++ b/drivers/pinctrl/freescale/Kconfig > > @@ -119,28 +119,28 @@ config PINCTRL_IMX7ULP > > > > config PINCTRL_IMX8MM > > tristate "IMX8MM pinctrl driver" > > - depends on ARCH_MXC > > + depends on ARCH_MXC || (COMPILE_TEST && OF) > > select PINCTRL_IMX > > I am not sure why you need the && OF, as we have a "select PINCTRL_IMX", > that already depends on OF. No, it's just an invalid dependency. PINCTRL_IMX can be selected without OF opened. > > Also, why was PINCTRL_IMX8DXL not updated? Ok, I'll update all pinctrl IMX. > > Thanks