From: Jonathan Cameron <jic23@kernel.org>
To: Jean-Baptiste Maneyrol <JManeyrol@invensense.com>
Cc: Daniel Palmer <daniel@0x0f.com>,
"lars@metafoo.de" <lars@metafoo.de>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] iio: imu: inv_mpu6050: Mark acpi match table as maybe unused
Date: Sat, 18 Sep 2021 18:59:37 +0100 [thread overview]
Message-ID: <20210918185937.1af9c5f5@jic23-huawei> (raw)
In-Reply-To: <BL0PR12MB5011F73C07A4EB499BCEBCC0C4D99@BL0PR12MB5011.namprd12.prod.outlook.com>
On Mon, 13 Sep 2021 12:19:10 +0000
Jean-Baptiste Maneyrol <JManeyrol@invensense.com> wrote:
> Hello,
>
> looks obviously good to me.
> Thanks for your patch.
>
> Acked-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
Applied to the togreg branch of iio.git and pushed out as testing for
0-day to see if it can find anything we missed.
Thanks,
Jonathan
>
> Thanks,
> JB
>
> From: Daniel Palmer <daniel@0x0f.com>
> Sent: Monday, September 13, 2021 13:29
> To: jic23@kernel.org <jic23@kernel.org>; lars@metafoo.de <lars@metafoo.de>; Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>; linux-iio@vger.kernel.org <linux-iio@vger.kernel.org>
> Cc: linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; Daniel Palmer <daniel@0x0f.com>
> Subject: [PATCH v2] iio: imu: inv_mpu6050: Mark acpi match table as maybe unused
>
> CAUTION: This email originated from outside of the organization. Please make sure the sender is who they say they are and do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> When building kernels without ACPI support the table is declared
> but is not used because ACPI_PTR() turns it into a NULL.
>
> Add the __maybe_unused attribute to stop the compiler whining.
>
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> ---
> Ignore the first version. I'm an idiot and generated a patch,
> check that it worked, noticed it didn't, fixed it up and then
> forgot to regenerate the patch before sending it.
>
> drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
> index 95f16951c8f4..3ef17e3f50e2 100644
> --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
> +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_i2c.c
> @@ -249,7 +249,7 @@ static const struct of_device_id inv_of_match[] = {
> };
> MODULE_DEVICE_TABLE(of, inv_of_match);
>
> -static const struct acpi_device_id inv_acpi_match[] = {
> +static const struct acpi_device_id __maybe_unused inv_acpi_match[] = {
> {"INVN6500", INV_MPU6500},
> { },
> };
prev parent reply other threads:[~2021-09-18 17:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 11:29 Daniel Palmer
2021-09-13 12:19 ` Jean-Baptiste Maneyrol
2021-09-18 17:59 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210918185937.1af9c5f5@jic23-huawei \
--to=jic23@kernel.org \
--cc=JManeyrol@invensense.com \
--cc=daniel@0x0f.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®