From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH net-next 3/5] net: phy: broadcom: Utilize appropriate suspend for BCM54810/11
Date: Mon, 20 Sep 2021 14:54:16 -0700 [thread overview]
Message-ID: <20210920215418.3247054-4-f.fainelli@gmail.com> (raw)
In-Reply-To: <20210920215418.3247054-1-f.fainelli@gmail.com>
Since we enable APD and DLL/RXC/TXC disable we need to use
bcm54xx_suspend() in order not to do a read/modify/write of the BMCR
register which is incompatible with the desired settings.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/phy/broadcom.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
index 952341e0baec..bb5104ae4610 100644
--- a/drivers/net/phy/broadcom.c
+++ b/drivers/net/phy/broadcom.c
@@ -903,7 +903,7 @@ static struct phy_driver broadcom_drivers[] = {
.config_aneg = bcm5481_config_aneg,
.config_intr = bcm_phy_config_intr,
.handle_interrupt = bcm_phy_handle_interrupt,
- .suspend = genphy_suspend,
+ .suspend = bcm54xx_suspend,
.resume = bcm54xx_resume,
.link_change_notify = bcm54xx_link_change_notify,
}, {
@@ -919,7 +919,7 @@ static struct phy_driver broadcom_drivers[] = {
.config_aneg = bcm5481_config_aneg,
.config_intr = bcm_phy_config_intr,
.handle_interrupt = bcm_phy_handle_interrupt,
- .suspend = genphy_suspend,
+ .suspend = bcm54xx_suspend,
.resume = bcm54xx_resume,
.link_change_notify = bcm54xx_link_change_notify,
}, {
--
2.25.1
next prev parent reply other threads:[~2021-09-21 2:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 21:54 [PATCH net-next 0/5] net: phy: broadcom: IDDQ-SR mode Florian Fainelli
2021-09-20 21:54 ` [PATCH net-next 1/5] net: phy: broadcom: Add " Florian Fainelli
2021-09-20 21:54 ` [PATCH net-next 2/5] net: phy: broadcom: Wire suspend/resume for BCM50610 and BCM50610M Florian Fainelli
2021-09-20 21:54 ` Florian Fainelli [this message]
2021-09-20 21:54 ` [PATCH net-next 4/5] net: bcmgenet: Request APD, DLL disable and IDDQ-SR Florian Fainelli
2021-09-20 21:54 ` [PATCH net-next 5/5] net: dsa: bcm_sf2: " Florian Fainelli
2021-09-21 10:10 ` [PATCH net-next 0/5] net: phy: broadcom: IDDQ-SR mode patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920215418.3247054-4-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®