From: Jackie Liu <liu.yun@linux.dev>
To: geert+renesas@glider.be
Cc: geert@linux-m68k.org, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, perex@perex.cz, liu.yun@linux.dev
Subject: [PATCH v2] ASoC: mediatek: make SND_SOC_MT8195 depends on COMMON_CLK
Date: Wed, 22 Sep 2021 10:36:42 +0800 [thread overview]
Message-ID: <20210922023642.3152359-1-liu.yun@linux.dev> (raw)
From: Jackie Liu <liuyun01@kylinos.cn>
After compiling with COMPILE_TEST, we are most likely to compile on a
different architecture, such as x86. At this time, it is possible that
the HAVE_CLK macro is not selected, resulting in compilation failure.
Avoid fail like:
Kernel: arch/x86/boot/bzImage is ready (#17)
ERROR: modpost: "clkdev_add" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
ERROR: modpost: "clkdev_drop" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
ERROR: modpost: "clk_unregister_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
ERROR: modpost: "clk_register_gate" [sound/soc/mediatek/mt8195/snd-soc-mt8195-afe.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:134: modules-only.symvers] Error 1
make[1]: *** Deleting file 'modules-only.symvers'
make: *** [Makefile:1783: modules] Error 2
Let's add the missing real dependencies!
HAVE_CLK (clkdev_add, clkdev_drop)
COMMON_CLK (clk_unregister_gate, clk_register_gate)
Fixes: 6746cc858259 ("ASoC: mediatek: mt8195: add platform driver")
Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Jackie Liu <liuyun01@kylinos.cn>
---
sound/soc/mediatek/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/mediatek/Kconfig b/sound/soc/mediatek/Kconfig
index 5a2f4667d50b..90356c8e1a3c 100644
--- a/sound/soc/mediatek/Kconfig
+++ b/sound/soc/mediatek/Kconfig
@@ -188,6 +188,7 @@ config SND_SOC_MT8192_MT6359_RT1015_RT5682
config SND_SOC_MT8195
tristate "ASoC support for Mediatek MT8195 chip"
depends on ARCH_MEDIATEK || COMPILE_TEST
+ depends on COMMON_CLK
select SND_SOC_MEDIATEK
help
This adds ASoC platform driver support for Mediatek MT8195 chip
--
2.25.1
reply other threads:[~2021-09-22 2:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210922023642.3152359-1-liu.yun@linux.dev \
--to=liu.yun@linux.dev \
--cc=alsa-devel@alsa-project.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®