From: Melissa Wen <melissa.srw@gmail.com>
To: Melissa Wen <mwen@igalia.com>
Cc: Cai Huoqing <caihuoqing@baidu.com>, Emma Anholt <emma@anholt.net>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/v3d: Make use of the helper function devm_platform_ioremap_resource_byname()
Date: Wed, 22 Sep 2021 09:11:25 +0100 [thread overview]
Message-ID: <20210922081125.qc4eaaxyfi6rjunr@smtp.gmail.com> (raw)
In-Reply-To: <20210920083134.hajvw6kpvfg3qitn@mail.igalia.com>
On 09/20, Melissa Wen wrote:
> On 09/01, Cai Huoqing wrote:
> > Use the devm_platform_ioremap_resource_byname() helper instead of
> > calling platform_get_resource_byname() and devm_ioremap_resource()
> > separately
> >
> > Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> > ---
> > drivers/gpu/drm/v3d/v3d_drv.c | 5 +----
> > 1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/v3d/v3d_drv.c b/drivers/gpu/drm/v3d/v3d_drv.c
> > index 9403c3b36aca..c1deab2cf38d 100644
> > --- a/drivers/gpu/drm/v3d/v3d_drv.c
> > +++ b/drivers/gpu/drm/v3d/v3d_drv.c
> > @@ -206,10 +206,7 @@ MODULE_DEVICE_TABLE(of, v3d_of_match);
> > static int
> > map_regs(struct v3d_dev *v3d, void __iomem **regs, const char *name)
> > {
> > - struct resource *res =
> > - platform_get_resource_byname(v3d_to_pdev(v3d), IORESOURCE_MEM, name);
> > -
> > - *regs = devm_ioremap_resource(v3d->drm.dev, res);
> > + *regs = devm_platform_ioremap_resource_byname(v3d_to_pdev(v3d), name);
> > return PTR_ERR_OR_ZERO(*regs);
> > }
> lgtm.
>
> Reviewed-by: Melissa Wen <mwen@igalia.com>
and applied to drm-misc-next.
Thanks,
Melissa
> >
> > --
> > 2.25.1
> >
prev parent reply other threads:[~2021-09-22 8:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 11:29 Cai Huoqing
2021-09-20 8:31 ` Melissa Wen
2021-09-22 8:11 ` Melissa Wen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210922081125.qc4eaaxyfi6rjunr@smtp.gmail.com \
--to=melissa.srw@gmail.com \
--cc=airlied@linux.ie \
--cc=caihuoqing@baidu.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mwen@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®