From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D6D2C433EF for ; Thu, 23 Sep 2021 13:15:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7239A61211 for ; Thu, 23 Sep 2021 13:15:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241232AbhIWNQ4 (ORCPT ); Thu, 23 Sep 2021 09:16:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234006AbhIWNQy (ORCPT ); Thu, 23 Sep 2021 09:16:54 -0400 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27A2FC061756 for ; Thu, 23 Sep 2021 06:15:21 -0700 (PDT) Received: by mail-qt1-x829.google.com with SMTP id 2so6119408qtw.1 for ; Thu, 23 Sep 2021 06:15:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/qBGTJ94J1mVUaKqjzNfrmv22QiJeX2c01+ZG5N5Dug=; b=nIK/43rfkMS55xMT6HEck5klqGQaWuQAs5hQCn0cBILgOPXazmLQSduge3zd+fy0xm ie+Yys8USJlUF7KPKscqJU5cEAPz4wIqws+OwGe5R4RN78Yp/813GM7br6Rr38n1D4mN 5Xbp6A6xRTIt+A6Ct9MnH2r782Ueh4Dbyu6XfGGXtoASC4KN6xRL6Gj6c1i7HQb2QrWZ HWeCGTP4dVC4jDBkxjmvEtGqjflTU6xCvoqaQImsUOLj1UwPAMfQpTr3lSIQncJG8+52 HAIqMFQ3Ukbg2pq0TkuE4jbe2oCc1vOba5x0GshDMOVW9Q6mzPv74TYGgKlpe0AQ8V/g 3G9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/qBGTJ94J1mVUaKqjzNfrmv22QiJeX2c01+ZG5N5Dug=; b=XNarebk4IecVSL3JhleER5jzop706ZZyckA7M7f969MVG8oBp0n+jPgsQdl/7pcMda cx6Iv7tJQserrqYp0uypymaLrPZxSvpzUQsHDuzAP3y3jE1kE5x5nUPWrqbB+WIzjvXi nUkBVGVlsiSCEzQr8lIxFFbY7041r+hewUkaYlYfF3ndQV67ZEh10PaS03FewFC/uQI8 IzYmRDpaA2fJoGYTEXT2zSxcQ4/g1NcaS52ArpHPOCP3LvFJJi1cxDKzAz+q/wfwiKbO KYZB5D2Tcj6Q/YgTqSqMcwAtRgmWjPdC3mzr4hZAMOUTD7TAZNrYn/oH0qAADvLLlsqN A/+Q== X-Gm-Message-State: AOAM533EEYdvdcKN2sOa2tnPN8Tt12suyHld4OoOSPmqINZCTRhErHwT fM8J+Lj7aFVFUQ1/eg5EP5GBQA== X-Google-Smtp-Source: ABdhPJyN7vkSS1Pa+Tln15YulpLlFsVxYMb7d1gGthyuSGhnPwjOs1ySYLoiJSd9J//5qQ0tBPG7Sg== X-Received: by 2002:ac8:7d46:: with SMTP id h6mr4752542qtb.162.1632402920265; Thu, 23 Sep 2021 06:15:20 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-129.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.129]) by smtp.gmail.com with ESMTPSA id y6sm579990qkj.26.2021.09.23.06.15.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 06:15:19 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1mTOZK-004Ps6-NZ; Thu, 23 Sep 2021 10:15:18 -0300 Date: Thu, 23 Sep 2021 10:15:18 -0300 From: Jason Gunthorpe To: "Marciniszyn, Mike" Cc: Bart Van Assche , Guo Zhi , "Dalessandro, Dennis" , "dledford@redhat.com" , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] infiniband hfi1: fix misuse of %x in ipoib_tx.c Message-ID: <20210923131518.GW3544071@ziepe.ca> References: <20210922134857.619602-1-qtxuning1999@sjtu.edu.cn> <276b9343-c23d-ac15-bb73-d7b42e7e7f0f@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 23, 2021 at 11:03:06AM +0000, Marciniszyn, Mike wrote: > > How about applying Guo's patch and adding a configuration option to the > > kernel for disabling pointer hashing for %p and related format specifiers? > > Pointer hashing is useful on production systems but not on development > > systems. > > The prints and traces are leave-behind and intended once in a distro > for field support. It doesn't matter, our security model is that drivers do not get to subvert the kASLR by unilaterally leaking memory layout information, so you have to get this fixed. Do not defeat the mechanisms to obscure kernel pointers in trace or print. Jason