From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62943C433EF for ; Fri, 24 Sep 2021 12:27:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BC7061241 for ; Fri, 24 Sep 2021 12:27:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343647AbhIXM31 (ORCPT ); Fri, 24 Sep 2021 08:29:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245733AbhIXM3N (ORCPT ); Fri, 24 Sep 2021 08:29:13 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA1CAC061574 for ; Fri, 24 Sep 2021 05:27:39 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id y89so24666277ede.2 for ; Fri, 24 Sep 2021 05:27:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Qi+zf2bdvOa9UR9wFZCL3fbUpqToUUKmha/pjGTdTMQ=; b=CnN9oEj+J4GtMs6JYBo5rmZzvjKY4yNBYe54W5lmAvc0Xy2wU34PuOpsoKVkby7AxW gki2tyHhV6eDm0oXJBPvaINVNx23xmt4zk3m5khvp1mN8+/3BYySQBdMvWqkUhtt956m kfAuxxVnS2W/Ofs0ObTWZDNev0JL7/C/MM3x7R7uWOMpsqwdCES5PelLz4VckjGJyCtn 4GacBH4bX9ssrvOepLHo7aDDbjGK0xd0spY3R7o15kRKgQw0op4MEdvejgfa7rCZ9obS AMeZwI04TDCfXs5WTWRJYhxG5oYF760kB8qSXQoendnBTxhX7HnexugnKcNts1HBJqJ/ sWig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Qi+zf2bdvOa9UR9wFZCL3fbUpqToUUKmha/pjGTdTMQ=; b=yC26OHffyEOaZyQr23hVYVOnkiwZTRB12dNJQ4lwTpbT5HsGz3Ydq98DrhI0z0BrJO FIZutJybw7p4mdCiCtEnQQ4vxlI7opPV9uQAGpfXDAjkPGiDnkeXaiVxvZqTG5YhLkDi fJliTbcekdRBNrBRTspOFP7+91yX5p2iYdI5RUD/b+ucu2xFea4HskeY8CepzCYqmHXt YWrtZgtEwS6nvqDNjEESwZq8imeSmXUwgwQpXNMzOnemzpHg0qbwJpY4OB+DY+Eyl6mG CW4OVunEpdTXuKbqHWUZNfKHj6fdWjckWf9bKJb2BUhV9VPfNG+KYxHtut+Ca7ZlROCE zh9A== X-Gm-Message-State: AOAM533YIOBnTNztq+9725EeCnUGWQF2DkeFQmSFl3PzT82n9x//+ter ArGy7SImre3ryW3Xcri68wI= X-Google-Smtp-Source: ABdhPJyN07c2oeIsr7KQYYz0nlPDopZ9R2gAH964rMRYs68ZkL6BcP35HRLqBw6Gc5kVBSXWqJ1MxA== X-Received: by 2002:a17:906:c246:: with SMTP id bl6mr10741802ejb.80.1632486458506; Fri, 24 Sep 2021 05:27:38 -0700 (PDT) Received: from localhost.localdomain.it (host-212-171-30-160.retail.telecomitalia.it. [212.171.30.160]) by smtp.gmail.com with ESMTPSA id v13sm4882522ejh.62.2021.09.24.05.27.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 05:27:38 -0700 (PDT) From: "Fabio M. De Francesco" To: Greg Kroah-Hartman , Larry Finger , Phillip Potter , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, David Laight , Dan Carpenter , Michael Straube , Martin Kaiser Cc: "Fabio M. De Francesco" Subject: [PATCH v10 09/16] staging: r8188eu: remove a buffer from rtw_writeN() Date: Fri, 24 Sep 2021 14:26:58 +0200 Message-Id: <20210924122705.3781-10-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210924122705.3781-1-fmdefrancesco@gmail.com> References: <20210924122705.3781-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove the unnecessary buffer "u8 buf[VENDOR_CMD_MAX_DATA_LEN]" and pass directly "data" to usbctrl_vendorreq(). Co-developed-by: Pavel Skripkin Signed-off-by: Pavel Skripkin Signed-off-by: Fabio M. De Francesco --- drivers/staging/r8188eu/hal/usb_ops_linux.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index 5dcab1ee4be0..8e4e578ed60b 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -171,14 +171,12 @@ int rtw_writeN(struct adapter *adapter, u32 addr, u32 length, u8 *data) struct io_priv *io_priv = &adapter->iopriv; struct intf_hdl *intf = &io_priv->intf; u16 value = addr & 0xffff; - u8 buf[VENDOR_CMD_MAX_DATA_LEN] = {0}; int ret; if (length > VENDOR_CMD_MAX_DATA_LEN) return _FAIL; - memcpy(buf, data, length); - ret = usbctrl_vendorreq(intf, value, buf, (length & 0xffff), REALTEK_USB_VENQT_WRITE); + ret = usbctrl_vendorreq(intf, value, data, (length & 0xffff), REALTEK_USB_VENQT_WRITE); return RTW_STATUS_CODE(ret); } -- 2.33.0