From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2240BC433F5 for ; Fri, 24 Sep 2021 12:28:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0D61660F24 for ; Fri, 24 Sep 2021 12:28:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343658AbhIXM3a (ORCPT ); Fri, 24 Sep 2021 08:29:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343605AbhIXM3O (ORCPT ); Fri, 24 Sep 2021 08:29:14 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42021C0613D3 for ; Fri, 24 Sep 2021 05:27:41 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id v10so30815897edj.10 for ; Fri, 24 Sep 2021 05:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xdFvvX5/HN7bvh9JTzeUFUGFd/lBuWQSjRE1lGqFFEU=; b=OgjdsnN4Ua1jK98rr1+qMkd+SRLUo9q7yLsln2Ibrtz+is/8y7YM7nsKVhY5xfnycH ldgA+bQZNJN9lQiwfDakdcigpKQ9m4VjmZygB89utZ9x+KcUOf253MXg50+fUj1L4Spx fdoh44TdzsrF4hzuQ/9WV1E7gkc6Obcttn0bNsd6ylB+RPcd8F8FIVbvl+qFjZh+johX oM7MQxaHNnGJTlzZXuLu+4kBIgZ9vTbb+zCF8GXpGRSzacr5jP/uZrrB1wAOWVpiVccL C04b+Sk/lWg7EIVUvjJlQpGm1D4EH1DaY4gHxbslpVZJBmklwR0NikO7M/a1NSmRZYFo gJXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xdFvvX5/HN7bvh9JTzeUFUGFd/lBuWQSjRE1lGqFFEU=; b=ocSB3usqlbyauwOKddrCUL9OXjsPXUekN0FJp512NLYispWh43nLW8hJluCtFhzIca /V21fO0zZdAR4haGcP4dLmIBPwNC5nuWF2BnQhHohQQktSHnTJ1rewzmNfLFJMIVlmdu ePB+XPkvEOIOq5GLEFD67E+wEbrHXN46hSV9lHWQZLZFMVEME/l0yDfXaQEoEX7rEeK8 4+7dRDrVby+8fTyz2b5wGLGnHSyxJRZDbSfmcfuK0hWZrfWC9u5E2tUapxfklnpUdy80 2H9S+q623UMlYEHw/OpiVoi1wfFMmha53VsAfqyS4wj0fcSg97Ovvh7E+Ila5glLZyhp 9awg== X-Gm-Message-State: AOAM530T3I8zdLH/HagoFHpOrxdsz942QZjy3m5NmJSyn9tckUV7laSV ZFSw1KIHc5ZsD7+4yDGsEKM= X-Google-Smtp-Source: ABdhPJxOlRd6a5Cf6Z3o7CvUwTXlsBH9q3aOm9xHyuPWjQ349ZTj+Mcs1IY0UoLFxqbJhjId3406AQ== X-Received: by 2002:a17:906:828c:: with SMTP id h12mr1614500ejx.414.1632486459878; Fri, 24 Sep 2021 05:27:39 -0700 (PDT) Received: from localhost.localdomain.it (host-212-171-30-160.retail.telecomitalia.it. [212.171.30.160]) by smtp.gmail.com with ESMTPSA id v13sm4882522ejh.62.2021.09.24.05.27.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 05:27:39 -0700 (PDT) From: "Fabio M. De Francesco" To: Greg Kroah-Hartman , Larry Finger , Phillip Potter , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, David Laight , Dan Carpenter , Michael Straube , Martin Kaiser Cc: "Fabio M. De Francesco" Subject: [PATCH v10 10/16] staging: r8188eu: remove a bitwise AND from rtw_writeN() Date: Fri, 24 Sep 2021 14:26:59 +0200 Message-Id: <20210924122705.3781-11-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210924122705.3781-1-fmdefrancesco@gmail.com> References: <20210924122705.3781-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove an unnecessary bitwise AND because "length" can never be greater than 0xffff since VENDOR_CMD_MAX_DATA_LEN is defined as '254'. Co-developed-by: Pavel Skripkin Signed-off-by: Pavel Skripkin Signed-off-by: Fabio M. De Francesco --- drivers/staging/r8188eu/hal/usb_ops_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index 8e4e578ed60b..3b50d2b5c0e3 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -176,7 +176,7 @@ int rtw_writeN(struct adapter *adapter, u32 addr, u32 length, u8 *data) if (length > VENDOR_CMD_MAX_DATA_LEN) return _FAIL; - ret = usbctrl_vendorreq(intf, value, data, (length & 0xffff), REALTEK_USB_VENQT_WRITE); + ret = usbctrl_vendorreq(intf, value, data, length, REALTEK_USB_VENQT_WRITE); return RTW_STATUS_CODE(ret); } -- 2.33.0