From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F888C433EF for ; Fri, 24 Sep 2021 12:27:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 784B360F24 for ; Fri, 24 Sep 2021 12:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343551AbhIXM3M (ORCPT ); Fri, 24 Sep 2021 08:29:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245757AbhIXM3E (ORCPT ); Fri, 24 Sep 2021 08:29:04 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98980C061756 for ; Fri, 24 Sep 2021 05:27:31 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id y89so24664776ede.2 for ; Fri, 24 Sep 2021 05:27:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L8J0b/n/pwhYzMH+qtOX6Qmp8dqFy4rk3PZYvNn2b4c=; b=WqFntFslHdbEtxPj6GYJhEgJGv3fIZa1OjjkCfHq5CyOPwyzzlcReo5OWpVc7zVdz0 J/5KAwLAxz1cfRhZ62JmpvJANPeDV+G6eM+S+6rjbvwam6qBHGsIP7hIdAL6qWeEzKft 7AEKmkfKYpr3pEYzpKYDsigdSTVBFhLClTqxuYMDHUj9w7bSwRoX8byPalrdGKmofuTx 5wGL0naUGWyq8SISv15KRCgKLxy/lI8wU0N16ShYuvNeElx5T+n2pj2PU1GKl/jFFgHJ yqaQJvDfXsxrpavXONAaH6IdA4Eye0gcD5wzdnNoSbkD4GR5fmvsZLvpJcwMXLkjZ8c7 MIbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L8J0b/n/pwhYzMH+qtOX6Qmp8dqFy4rk3PZYvNn2b4c=; b=A5+tLKNWgp+3iS6AoN8uzyoziYQfusECogBYiYKHC3kastaWrZLtpgWasd/M1EQqUD jdo5hu2BoY8K5KUp6Tm5NVyKXhOpgoh/u9ax7gsh3zfcpQ8a5xT6uXNutZvYsUXCB1XD NBw7VXQohJZCosgUKwCjwZ+egHbC8LDvWUD9CEmvQJ3keombXYBLp1ButA6IOpjxZvax EKTEeA0kKtp6eA2S8B7QHdkdcgoQGckyLmwA8E9fHJEaAOcAv6F8i3qO1dcVX2JOVpta DNXCa5nqjYjKeNDQYKNWPIqreQR28xYa0eH1sxyJS0KVezUChbQhSvf5jaw+W0HQn+lo 5Inw== X-Gm-Message-State: AOAM532XLbohj4uQ6ZIjbnSp2YHyneGsAGQYnoKnMvUH88npRwiI7mD6 aQzuWbZqYo7JLYNRS8GyPmM= X-Google-Smtp-Source: ABdhPJzCWMbqW4O1631UYz1NiKax6LgkFOh4eEd37wdLvM2744vuBoRxBKQSYzk8rHmsSnrLFBFlaA== X-Received: by 2002:a17:906:584:: with SMTP id 4mr11015083ejn.56.1632486450230; Fri, 24 Sep 2021 05:27:30 -0700 (PDT) Received: from localhost.localdomain.it (host-212-171-30-160.retail.telecomitalia.it. [212.171.30.160]) by smtp.gmail.com with ESMTPSA id v13sm4882522ejh.62.2021.09.24.05.27.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 05:27:29 -0700 (PDT) From: "Fabio M. De Francesco" To: Greg Kroah-Hartman , Larry Finger , Phillip Potter , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, David Laight , Dan Carpenter , Michael Straube , Martin Kaiser Cc: "Fabio M. De Francesco" Subject: [PATCH v10 03/16] staging: r8188eu: remove test in usbctrl_vendorreq() Date: Fri, 24 Sep 2021 14:26:52 +0200 Message-Id: <20210924122705.3781-4-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210924122705.3781-1-fmdefrancesco@gmail.com> References: <20210924122705.3781-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove unnecessary test for "!io_buf" in usbctrl_vendorreq(). This test is not necessary because io_buf has been assigned with the address of a region of dynamically allocated memory (dvobj->usb_alloc_vendor_req_buf) by rtw_init_intf_priv() in os_dep/usb_intf.c. Co-developed-by: Pavel Skripkin Signed-off-by: Pavel Skripkin Signed-off-by: Fabio M. De Francesco --- drivers/staging/r8188eu/hal/usb_ops_linux.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index 84ec7c1346b1..61a016e3608f 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -34,12 +34,6 @@ static int usbctrl_vendorreq(struct intf_hdl *intf, u16 value, void *data, u16 l /* Acquire IO memory for vendorreq */ io_buf = dvobjpriv->usb_vendor_req_buf; - if (!io_buf) { - DBG_88E("[%s] io_buf == NULL\n", __func__); - status = -ENOMEM; - goto release_mutex; - } - if (requesttype == REALTEK_USB_VENQT_READ) pipe = usb_rcvctrlpipe(udev, 0);/* read_in */ else @@ -91,7 +85,7 @@ static int usbctrl_vendorreq(struct intf_hdl *intf, u16 value, void *data, u16 l if ((value >= FW_8188E_START_ADDRESS && value <= FW_8188E_END_ADDRESS) || status == len) break; } -release_mutex: + mutex_unlock(&dvobjpriv->usb_vendor_req_mutex); exit: return status; -- 2.33.0