From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68D6CC433EF for ; Fri, 24 Sep 2021 12:27:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BCB7610FD for ; Fri, 24 Sep 2021 12:27:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343695AbhIXM3Z (ORCPT ); Fri, 24 Sep 2021 08:29:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245751AbhIXM3M (ORCPT ); Fri, 24 Sep 2021 08:29:12 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88B19C061756 for ; Fri, 24 Sep 2021 05:27:38 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id eg28so35660528edb.1 for ; Fri, 24 Sep 2021 05:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XcIedgRKd4A/e9/Vk0iYyZm/XbgKRfJOO6XAQxSeG7Y=; b=YuZvnUUSmVCb3vxkpGs6qUEG9jhB3yRhpRsoB3F+EKLGJDD+rQoqlEa0Zt6p+7tNZT JxziWlPx2D5CuPy/4S9zcXxaYK0KP6ncnPX04B154l/2uQ6seiF8qHkESdtKD8KSeNP7 Xxnfu8XK2i6nixRt3Jt5/rvHbgayQBO47bHElcju9ttnzn7Jvihv5CCjy/HtCY90pUgg tcrrLvF97OCZu3824HRZYeGsRGAevQJw23a+yRw53JnAq8jvukFy7eN3mRUTZrdskPDW iVKc6tOK/39qkujf2DDy5r/rvSpMuRetphZSno33pU8dGpTXEBC8R9z5NsAtoy4FRTX9 vbbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XcIedgRKd4A/e9/Vk0iYyZm/XbgKRfJOO6XAQxSeG7Y=; b=vGAp2Hjpymg8ETn2vlTUsKu9ErsA8mmyZJNcAFe+h6IgGGBD32H5faQ+rhpmBbmACE diiPZUoscQFukuVBdGQrbqYTksRBLUflyA0w1Atn2kmL9xZJIeb71ZuL8km9xmuCAvb1 q9Rn6oTw+Lc13qTyhQplQM4NRYPJNdlO4exQuUQZ1nQnPA+c1ClxT1XF++gUGffFps8P WLwd8QrQgc2H+9P/U7oClYsFg+tlYH5iYuF/FWwYMNIVJAlE2MWbkMydzqiL61xJiAxm HLLXUsEY9PPegS7nMj/7FV2LVfnKOUxFFNbSQ+8ILqSqGPL6Il1DoVYdkAK6dJ3JZ5mJ 1dyw== X-Gm-Message-State: AOAM532ux3+KWPY3L/JoKvxIyDoxdUvZ7/VCXq5ciwnFFOWjglyBSy/L pLR4+S95l9TiHDr3K6zgsoA= X-Google-Smtp-Source: ABdhPJxuO9TM+vll1WneXs8MBnfPZ4DyGqCotBs43lRFt5JYEPZuQlVi5kx6gwbfNgLDCcySz5hRBQ== X-Received: by 2002:a17:906:fc0b:: with SMTP id ov11mr10878057ejb.22.1632486457160; Fri, 24 Sep 2021 05:27:37 -0700 (PDT) Received: from localhost.localdomain.it (host-212-171-30-160.retail.telecomitalia.it. [212.171.30.160]) by smtp.gmail.com with ESMTPSA id v13sm4882522ejh.62.2021.09.24.05.27.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Sep 2021 05:27:36 -0700 (PDT) From: "Fabio M. De Francesco" To: Greg Kroah-Hartman , Larry Finger , Phillip Potter , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, David Laight , Dan Carpenter , Michael Straube , Martin Kaiser Cc: "Fabio M. De Francesco" Subject: [PATCH v10 08/16] staging: r8188eu: change the type of a variable in rtw_write16() Date: Fri, 24 Sep 2021 14:26:57 +0200 Message-Id: <20210924122705.3781-9-fmdefrancesco@gmail.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210924122705.3781-1-fmdefrancesco@gmail.com> References: <20210924122705.3781-1-fmdefrancesco@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Change the type of "data" from __le32 to __le16 in rtw_write16(). The argument "val", which is u16, after being conditionally swapped to little endian, is assigned to "data"; therefore, __le16 is the most suitable type for "data". Remove the bitwise AND of "val" with 0xffff because it is redundant. Use cpu_to_le16() because "data" is __le16. Co-developed-by: Pavel Skripkin Signed-off-by: Pavel Skripkin Signed-off-by: Fabio M. De Francesco --- drivers/staging/r8188eu/hal/usb_ops_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index 95cd7a6bc28b..5dcab1ee4be0 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -145,7 +145,7 @@ int rtw_write16(struct adapter *adapter, u32 addr, u16 val) struct io_priv *io_priv = &adapter->iopriv; struct intf_hdl *intf = &io_priv->intf; u16 value = addr & 0xffff; - __le32 data = cpu_to_le32(val & 0x0000ffff); + __le16 data = cpu_to_le16(val); int ret; ret = usbctrl_vendorreq(intf, value, &data, 2, REALTEK_USB_VENQT_WRITE); -- 2.33.0