mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] usb: ehci: Fix a function name in comments
Date: Sat, 25 Sep 2021 10:45:13 -0400	[thread overview]
Message-ID: <20210925144513.GA308698@rowland.harvard.edu> (raw)
In-Reply-To: <20210925124920.1564-1-caihuoqing@baidu.com>

On Sat, Sep 25, 2021 at 08:49:17PM +0800, Cai Huoqing wrote:
> Use dma_map_single() instead of pci_map_single(),
> because only dma_map_single() is called here.
> 
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>

Acked-by: Alan Stern <stern@rowland.harvard.edu>

> ---
>  drivers/usb/host/ehci-hcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index 144080321629..3d82e0b853be 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -588,7 +588,7 @@ static int ehci_run (struct usb_hcd *hcd)
>  	 * hcc_params controls whether ehci->regs->segment must (!!!)
>  	 * be used; it constrains QH/ITD/SITD and QTD locations.
>  	 * dma_pool consistent memory always uses segment zero.
> -	 * streaming mappings for I/O buffers, like pci_map_single(),
> +	 * streaming mappings for I/O buffers, like dma_map_single(),
>  	 * can return segments above 4GB, if the device allows.
>  	 *
>  	 * NOTE:  the dma mask is visible through dev->dma_mask, so
> -- 
> 2.25.1
> 

      parent reply	other threads:[~2021-09-25 14:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25 12:49 Cai Huoqing
2021-09-25 12:49 ` [PATCH 2/3] usb: host: fotg210: " Cai Huoqing
2021-09-25 12:49 ` [PATCH 3/3] usb: host: oxu210hp: " Cai Huoqing
2021-09-25 14:45 ` Alan Stern [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210925144513.GA308698@rowland.harvard.edu \
    --to=stern@rowland.harvard.edu \
    --cc=caihuoqing@baidu.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®