From: tommy-huang <tommy_huang@aspeedtech.com>
To: <joel@jms.id.au>, <airlied@linux.ie>, <daniel@ffwll.ch>,
<robh+dt@kernel.org>, <andrew@aj.id.au>,
<linux-aspeed@lists.ozlabs.org>,
<dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Cc: <BMC-SW@aspeedtech.com>
Subject: [PATCH 4/6] HACK: drm/aspeed: INTR_STS hadndling
Date: Tue, 28 Sep 2021 10:57:01 +0800 [thread overview]
Message-ID: <20210928025703.10909-5-tommy_huang@aspeedtech.com> (raw)
In-Reply-To: <20210928025703.10909-1-tommy_huang@aspeedtech.com>
From: Joel Stanley <joel@jms.id.au>
The 2600 uses this register differently. THis is a TODO to come up with
a method of handling that.
Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: tommy-huang <tommy_huang@aspeedtech.com>
---
drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
index ea9cb0a4f16c..33095477cc03 100644
--- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
+++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c
@@ -126,7 +126,8 @@ static irqreturn_t aspeed_gfx_irq_handler(int irq, void *data)
if (reg & CRT_CTRL_VERTICAL_INTR_STS) {
drm_crtc_handle_vblank(&priv->pipe.crtc);
- writel(reg, priv->base + CRT_CTRL1);
+ /* TODO */
+ writel(CRT_CTRL_VERTICAL_INTR_STS, priv->base + CRT_STATUS);
return IRQ_HANDLED;
}
--
2.17.1
next prev parent reply other threads:[~2021-09-28 2:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 2:56 [PATCH 0/6] *** Add AST2600 GFX node *** tommy-huang
2021-09-28 2:56 ` [PATCH 1/6] ARM: dts: aspeed: Add GFX node to AST2600 tommy-huang
2021-09-28 2:56 ` [PATCH 2/6] ARM: dts: aspeed: ast2600-evb: Enable GFX device tommy-huang
2021-09-28 2:57 ` [PATCH 3/6] drm/aspeed: Add AST2600 support tommy-huang
2021-09-28 2:57 ` tommy-huang [this message]
2021-09-28 2:57 ` [PATCH 5/6] HACK: drm/aspeed: Paramterise modes tommy-huang
2021-09-28 2:57 ` [PATCH 6/6] dt-bindings: gpu: Add ASPEED GFX bindings document tommy-huang
2021-10-04 18:24 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928025703.10909-5-tommy_huang@aspeedtech.com \
--to=tommy_huang@aspeedtech.com \
--cc=BMC-SW@aspeedtech.com \
--cc=airlied@linux.ie \
--cc=andrew@aj.id.au \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®