From: Yafang Shao <laoar.shao@gmail.com>
To: akpm@linux-foundation.org, pmladek@suse.com,
peterz@infradead.org, valentin.schneider@arm.com,
keescook@chromium.org, mathieu.desnoyers@efficios.com,
qiang.zhang@windriver.com, robdclark@chromium.org,
viro@zeniv.linux.org.uk, christian@brauner.io,
dietmar.eggemann@arm.com
Cc: linux-kernel@vger.kernel.org, Yafang Shao <laoar.shao@gmail.com>
Subject: [PATCH 0/5] kthread: increase the size of kthread's comm
Date: Wed, 29 Sep 2021 11:50:31 +0000 [thread overview]
Message-ID: <20210929115036.4851-1-laoar.shao@gmail.com> (raw)
When I was implementing a new kthread cfs_migration [1], I found the
comm of it is trucated due to the limitation of TASK_COMM_LEN. After I
checked the other kthreads, I found some of them are also truncated, for
example,
rcu_tasks_kthre
rcu_tasks_rude_
rcu_tasks_trace
ecryptfs-kthrea
vfio-irqfd-clea
ext4-rsv-conver
jbd2/nvme0n1p2-
...
Besides the in-tree kthreads listed above, the out-of-tree kthreads may
also be trucated, for example,
rtase_work_queu
nvidia-modeset/
UVM global queu
UVM deferred re
...
That motivates me to do this improvement.
This patch increases the size of ktread's comm from 16 to 24, which is
the same with workqueue's. After this change, the name of kthread can be
fully displayed in /proc/[pid]/comm, for example,
rcu_tasks_kthread
rcu_tasks_rude_kthread
rcu_tasks_trace_kthread
ecryptfs-kthread
vfio-irqfd-cleanup
ext4-rsv-conversion
jbd2/nvme0n1p2-8
...
Because there're only a few of kthreads, so it won't increase too much
memory consumption.
After this improvement, if the comm of a kthread is still trucated, a
warning will be displayed. Below is the result of my test case -
__kthread_create_on_node:410: comm of pid 14 is truncated from "I-am-a-kthread-with-long-name" to "I-am-a-kthread-with-lon"
[1]. https://lore.kernel.org/lkml/YMmlAP%2FQhE6SWhCF@hirez.programming.kicks-ass.net/
Yafang Shao (5):
kernel: replace sizeof(task->comm) with TASK_COMM_LEN
kernel/fork: allocate task->comm dynamicly
kernel/sched: improve the BUILD_BUG_ON() in get_task_comm()
kernel: increase the size of kthread's comm
kernel/kthread: show a warning if kthread's comm is still trucated
arch/ia64/kernel/mca.c | 6 +++---
drivers/block/drbd/drbd_main.c | 2 +-
drivers/hwtracing/stm/core.c | 2 +-
drivers/tty/tty_audit.c | 2 +-
fs/exec.c | 5 ++++-
include/linux/sched.h | 6 ++++--
kernel/audit.c | 4 ++--
kernel/auditsc.c | 4 ++--
kernel/capability.c | 4 ++--
kernel/fork.c | 26 ++++++++++++++++++++++++++
kernel/futex.c | 2 +-
kernel/kthread.c | 8 ++++++--
kernel/sys.c | 2 +-
kernel/trace/blktrace.c | 2 +-
security/lsm_audit.c | 4 ++--
security/selinux/selinuxfs.c | 2 +-
security/yama/yama_lsm.c | 2 +-
sound/core/oss/pcm_oss.c | 2 +-
18 files changed, 60 insertions(+), 25 deletions(-)
--
2.17.1
next reply other threads:[~2021-09-29 11:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 11:50 Yafang Shao [this message]
2021-09-29 11:50 ` [PATCH 1/5] kernel: replace sizeof(task->comm) with TASK_COMM_LEN Yafang Shao
2021-09-29 18:09 ` Kees Cook
2021-09-30 12:27 ` Yafang Shao
2021-10-03 3:31 ` Al Viro
2021-10-03 14:14 ` Yafang Shao
2021-09-29 11:50 ` [PATCH 2/5] kernel/fork: allocate task->comm dynamicly Yafang Shao
2021-09-29 13:08 ` Yafang Shao
2021-09-29 18:11 ` Kees Cook
2021-09-30 12:41 ` Yafang Shao
2021-09-30 14:51 ` Petr Mladek
2021-10-01 11:58 ` Yafang Shao
2021-09-29 11:50 ` [PATCH 3/5] kernel/sched: improve the BUILD_BUG_ON() in get_task_comm() Yafang Shao
2021-09-29 18:12 ` Kees Cook
2021-09-30 12:43 ` Yafang Shao
2021-09-29 11:50 ` [PATCH 4/5] kernel: increase the size of kthread's comm Yafang Shao
2021-09-29 18:19 ` Kees Cook
2021-09-30 12:53 ` Yafang Shao
2021-09-29 11:50 ` [PATCH 5/5] kernel/kthread: show a warning if kthread's comm is still trucated Yafang Shao
2021-09-29 18:20 ` Kees Cook
2021-09-30 12:54 ` Yafang Shao
2021-09-30 15:17 ` Petr Mladek
2021-10-01 11:59 ` Yafang Shao
2021-10-03 3:41 ` [PATCH 0/5] kthread: increase the size of kthread's comm Al Viro
2021-10-03 14:20 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210929115036.4851-1-laoar.shao@gmail.com \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=christian@brauner.io \
--cc=dietmar.eggemann@arm.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=qiang.zhang@windriver.com \
--cc=robdclark@chromium.org \
--cc=valentin.schneider@arm.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®