mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Keoseong Park <keosung.park@samsung.com>
To: "jaegeuk@kernel.org" <jaegeuk@kernel.org>,
	"chao@kernel.org" <chao@kernel.org>
Cc: "linux-f2fs-devel@lists.sourceforge.net" 
	<linux-f2fs-devel@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"tanghuan@vivo.com" <tanghuan@vivo.com>,
	"changfengnan@vivo.com" <changfengnan@vivo.com>,
	Daejun Park <daejun7.park@samsung.com>,
	Jinyoung CHOI <j-young.choi@samsung.com>,
	Sung-Jun Park <sungjun07.park@samsung.com>
Subject: [PATCH v2] f2fs: fix to use WHINT_MODE
Date: Thu, 30 Sep 2021 09:59:39 +0900	[thread overview]
Message-ID: <20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p7> (raw)
In-Reply-To: <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p7>

Since active_logs can be set to 2 or 4 or NR_CURSEG_PERSIST_TYPE(6),
it cannot be set to NR_CURSEG_TYPE(8).
That is, whint_mode is always off.

Therefore, the condition is changed from NR_CURSEG_TYPE to NR_CURSEG_PERSIST_TYPE.

Cc: Chao Yu <chao@kernel.org>
Reported-by: Huan Tang <tanghuan@vivo.com>
Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
Signed-off-by: Keoseong Park <keosung.park@samsung.com>
---
v1 -> v2:
	* Merge Signed-off and Reported tags for the same fix patch.

 fs/f2fs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 78ebc306ee2b..86eeb019cc52 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -1292,7 +1292,7 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
 	/* Not pass down write hints if the number of active logs is lesser
 	 * than NR_CURSEG_PERSIST_TYPE.
 	 */
-	if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_TYPE)
+	if (F2FS_OPTION(sbi).active_logs != NR_CURSEG_PERSIST_TYPE)
 		F2FS_OPTION(sbi).whint_mode = WHINT_MODE_OFF;
 
 	if (f2fs_sb_has_readonly(sbi) && !f2fs_readonly(sbi->sb)) {
-- 
2.17.1

       reply	other threads:[~2021-09-30  0:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p7>
2021-09-30  0:59 ` Keoseong Park [this message]
2021-10-09  4:24   ` Chao Yu
     [not found]   ` <CGME20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p8>
2021-10-12  2:16     ` Keoseong Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210930005939epcms2p7303bf6f96c824720f824989746491cba@epcms2p7 \
    --to=keosung.park@samsung.com \
    --cc=changfengnan@vivo.com \
    --cc=chao@kernel.org \
    --cc=daejun7.park@samsung.com \
    --cc=j-young.choi@samsung.com \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sungjun07.park@samsung.com \
    --cc=tanghuan@vivo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®